Skip to content

New Chrome breaks three panel scrolling #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcollins-g opened this issue Feb 1, 2019 · 4 comments
Closed

New Chrome breaks three panel scrolling #1921

jcollins-g opened this issue Feb 1, 2019 · 4 comments
Assignees
@jcollins-g
Labels
area-web-design Something a web designer interested in helping could do. customer-flutter Issues originating from important to Flutter customer-google3 Issues originating from or important to Angular P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jcollins-g
Copy link
Contributor

At some point very recently, three panel scrolling broke completely on dartdoc generated pages when using Chrome (with the latest update?). It is now all one big giant page, which is not how it is supposed to work.
@jcollins-g jcollins-g added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P1 A high priority bug; for example, a single project is unusable or has many test failures customer-flutter Issues originating from important to Flutter customer-google3 Issues originating from or important to Angular area-web-design Something a web designer interested in helping could do. labels Feb 1, 2019
@jcollins-g jcollins-g self-assigned this Feb 1, 2019
@jcollins-g
Copy link
Contributor Author

Safari still works. This may be because we are using webkit scrolling.

@jcollins-g
Copy link
Contributor Author

thanks to some sleuthing by @devoncarew and I, it seems that this flex-box rendering issue may be to blame:

https://bugs.chromium.org/p/chromium/issues/detail?id=927066

@hibachrach
Copy link

hibachrach commented Feb 1, 2019 •
edited
Loading

This also the behavior experienced in Firefox (and has been for a while it seems), which makes sense given that the Chrome change was to align with Firefox and the Flexbox spec.

@jcollins-g jcollins-g mentioned this issue Feb 1, 2019
Merged
@jcollins-g
Copy link
Contributor Author

#1922 fixes the issue. I think this going out with 0.18.1 will be good enough, but if for some reason that release gets blocked I'll consider a 0.18.0+1 with only that PR added to the 0.18.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcollins-g jcollins-g

Labels
area-web-design Something a web designer interested in helping could do. customer-flutter Issues originating from important to Flutter customer-google3 Issues originating from or important to Angular P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hibachrach @jcollins-g