Skip to content

'Properties' link in masthead is broken in Enums #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filiph opened this issue Jul 28, 2016 · 3 comments
Closed

'Properties' link in masthead is broken in Enums #1225

filiph opened this issue Jul 28, 2016 · 3 comments
Assignees
Labels
area-web-design Something a web designer interested in helping could do. P3 A lower priority bug or feature request

Comments

@filiph
Copy link

filiph commented Jul 28, 2016

Reproduce (on api.dartlang.org):

  1. Open an Enum page like https://api.dartlang.org/stable/1.18.0/dart-io/FileLock-class.html
  2. Click on PROPERTIES in the masthead

Expected result: page jumps to Properties of the Enum

Actual result: nothing happens

The link goes to #properties, which is a non-existent anchor on the page. There is an anchor for #instance-properties, though.

@filiph filiph added the P3 A lower priority bug or feature request label Jul 28, 2016
@chalin
Copy link
Contributor

chalin commented Dec 21, 2016

Yes, we're still seeing this for the AngularDart docs; e.g., https://webdev.dartlang.org/angular/api/angular2.compiler/PropertyBindingType-class

cc @kwalrath

@jcollins-g jcollins-g added the area-web-design Something a web designer interested in helping could do. label Apr 10, 2017
@jcollins-g jcollins-g self-assigned this Apr 14, 2017
@chalin
Copy link
Contributor

chalin commented Apr 14, 2017

Just curious, do we have tests cases covering this -- and other recently closed -- issues?

@jcollins-g
Copy link
Contributor

There is presently no integration test that verifies the correctness of masthead links on generated pages specifically, but these are covered by the somewhat less-than-adequate generated files test. (Seeing as that used to verify that it was wrong, that's why I consider it less than adequate).

Other issues generally have had tests written for them, or required work like #1360.

We can certainly improve the grind link checker further (see newly filed #1376) for this specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-design Something a web designer interested in helping could do. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

3 participants