upgrade analyzer, add more tests, skip tests we don't have a solution for right now

Author: sethladd

lib/markdown_processor.dart

@@ -22,8 +22,6 @@ import 'package:markdown/markdown.dart' as md;
 import 'src/html_utils.dart' show htmlEscape;
 import 'src/model.dart';
 
-import 'src/debug.dart';
-
 final List<md.InlineSyntax> _markdown_syntaxes = [new _InlineCodeSyntax()];
 
 // We don't emit warnings currently: #572.
@@ -86,7 +84,6 @@ class Documentation {
 
 String renderMarkdownToHtml(String text, [ModelElement element]) {
   md.Node _linkResolver(String name) {
-    debugger(when: element != null && element.name == 'doAwesomeStuff');
     NodeList<CommentReference> commentRefs = _getCommentRefs(element);
     return new md.Text(_linkDocReference(name, element, commentRefs));
   }
@@ -149,7 +146,6 @@ NodeList<CommentReference> _getCommentRefs(ModelElement modelElement) {
 String _getMatchingLink(
     String codeRef, ModelElement element, List<CommentReference> commentRefs,
     {bool isConstructor: false}) {
-  debugger(when: element != null && element.name == 'doAwesomeStuff');
   if (commentRefs == null) return null;
 
   Element refElement;

pubspec.lock

@@ -4,7 +4,7 @@ packages:
   analyzer:
     description: analyzer
     source: hosted
-    version: "0.25.2"
+    version: "0.26.0"
   ansicolor:
     description: ansicolor
     source: hosted
@@ -88,7 +88,7 @@ packages:
   markdown:
     description: markdown
     source: hosted
-    version: "0.7.1+2"
+    version: "0.7.1+3"
   matcher:
     description: matcher
     source: hosted
@@ -148,7 +148,7 @@ packages:
   shelf_static:
     description: shelf_static
     source: hosted
-    version: "0.2.2"
+    version: "0.2.3"
   shelf_web_socket:
     description: shelf_web_socket
     source: hosted
@@ -180,7 +180,7 @@ packages:
   test:
     description: test
     source: hosted
-    version: "0.12.3+8"
+    version: "0.12.3+9"
   unscripted:
     description: unscripted
     source: hosted

pubspec.yaml

@@ -7,7 +7,7 @@ homepage: https://github.com/dart-lang/dartdoc
 environment:
   sdk: '>=1.9.0 <2.0.0' # when we go to 1.12, bump analyzer version
 dependencies:
-  analyzer: ^0.25.0
+  analyzer: '>=0.25.0 <0.27.0'
   args: ^0.13.0
   cli_util: ^0.0.1
   html: ^0.12.1

test/model_test.dart

@@ -228,9 +228,19 @@ void main() {
             '<a href="fake/BaseForDocComments-class.html">BaseForDocComments</a>'));
       });
 
-      test('links to a reference to a top-level const', () {
+      test(
+          'links to a reference to a top-level const with multiple underscores',
+          () {
         expect(
             docsAsHtml, contains('<a href="">NAME_WITH_TWO_UNDERSCORES</a>'));
+      }, skip: 'Wait for https://github.com/dart-lang/dartdoc/issues/768');
+
+      // remove this test when the above is fixed. just here to track when
+      // the behavior changes
+      test(
+          'literally renders a reference to a top-level const with multiple underscores',
+          () {
+        expect(docsAsHtml, contains('[NAME_WITH_TWO_UNDERSCORES]'));
       });
 
       test('links to a method in this class', () {
@@ -263,20 +273,24 @@ void main() {
             contains('<a href="">css.theOnlyThingInTheLibrary</a>'));
       }, skip: 'Wait for https://github.com/dart-lang/dartdoc/issues/767 to be fixed');
 
+      // remove this test when the above test is fixed. just here to
+      // track when the behavior changes
       test('codeifies a prefixed top-level variable an imported lib', () {
         expect(docsAsHtml, contains(
             '<code class="prettyprint lang-dart">css.theOnlyThingInTheLibrary</code>'));
       });
+
+      test('links to a name with a single underscore', () {
+        expect(docsAsHtml, contains(
+            '<a href="fake/NAME_SINGLEUNDERSCORE.html">NAME_SINGLEUNDERSCORE</a>'));
+      });
     });
 
     test('multi-underscore names in brackets do not become italicized', () {
       expect(short.documentation, contains('[NAME_WITH_TWO_UNDERSCORES]'));
-      expect(short.documentation, contains('[NAME_SINGLEUNDERSCORE]'));
       expect(short.documentationAsHtml, contains(
           '<a href="fake/NAME_WITH_TWO_UNDERSCORES.html">NAME_WITH_TWO_UNDERSCORES</a>'));
-      expect(short.documentationAsHtml, contains(
-          '<a href="fake/NAME_SINGLEUNDERSCORE.html">NAME_SINGLEUNDERSCORE</a>'));
-    });
+    }, skip: 'Wait for https://github.com/dart-lang/dartdoc/issues/768');
 
     test('still has brackets inside code blocks', () {
       expect(topLevelFunction.documentationAsHtml,

test_package/lib/fake.dart

@@ -386,23 +386,25 @@ class ExtraSpecialList<E> extends SpecialList {}
 class BaseForDocComments {
   /// Takes a [value] and returns a String.
   ///
-  /// This methods is inside of [BaseForDocComments] class
+  /// This methods is inside of [BaseForDocComments] class xx
   ///
-  /// Also [NAME_WITH_TWO_UNDERSCORES] which is a top-level const
+  /// Also [NAME_WITH_TWO_UNDERSCORES] which is a top-level const xx
   ///
-  /// Returns a [String]
+  /// Also a single underscore: [NAME_SINGLEUNDERSCORE]
   ///
-  /// Reference to another method in this class [anotherMethod]
+  /// Returns a [String] xx
   ///
-  /// Reference to a top-level function in this library [topLevelFunction]
+  /// Reference to another method in this class [anotherMethod] xx
   ///
-  /// Reference to a top-level function in another library (example lib) [function1]
+  /// Reference to a top-level function in this library [topLevelFunction] xx
   ///
-  /// Reference to a class in example lib [Apple]
+  /// Reference to a top-level function in another library (example lib) [function1] xx
   ///
-  /// Reference to a top-level const in another library [incorrectDocReference]
+  /// Reference to a class in example lib [Apple] xx
   ///
-  /// Reference to prefixed-name from another lib [css.theOnlyThingInTheLibrary]
+  /// Reference to a top-level const in another library [incorrectDocReference] xx
+  ///
+  /// Reference to prefixed-name from another lib [css.theOnlyThingInTheLibrary] xx
   String doAwesomeStuff(int value) => null;
 
   void anotherMethod() {}