Cleanup some fromYamlMap usage; other simplifications

Author: srawlins

analysis_options.yaml

@@ -6,7 +6,6 @@ analyzer:
   errors:
     unused_import: warning
     unused_shown_name: warning
-    todo: ignore
   exclude:
     - 'doc/**'
     - 'lib/src/third_party/pkg/**'

lib/dartdoc.dart

@@ -111,7 +111,9 @@ class Dartdoc {
       StreamController(sync: true);
 
   Dartdoc._(this.config, this.generator, this.packageBuilder) {
-    outputDir = config.resourceProvider.getFolder(config.output)..create();
+    outputDir = config.resourceProvider
+        .getFolder(config.resourceProvider.pathContext.absolute(config.output))
+          ..create();
   }
 
   /// An asynchronous factory method that builds Dartdoc's file writers
@@ -229,8 +231,9 @@ class Dartdoc {
         throw DartdocFailure(
             'dartdoc encountered $errorCount errors while processing.');
       }
-      logInfo('Success! Docs generated into '
-          '${dartdocResults.packageGraph.resourceProvider.pathContext.absolute(dartdocResults.outDir.path)}');
+      var outDirPath = config.resourceProvider.pathContext
+          .absolute(dartdocResults.outDir.path);
+      logInfo('Success! Docs generated into $outDirPath');
       return dartdocResults;
     } finally {
       // TODO: necessary?

lib/options.dart

@@ -18,11 +18,13 @@ class DartdocProgramOptionContext extends DartdocGeneratorOptionContext
 }
 
 Future<List<DartdocOption<bool>>> createDartdocProgramOptions(
-    ResourceProvider resourceProvider) async {
+    PackageMetaProvider packageMetaProvider) async {
+  var resourceProvider = packageMetaProvider.resourceProvider;
   return [
     DartdocOptionArgOnly<bool>('generateDocs', true, resourceProvider,
         help:
-            'Generate docs into the output directory (or only display warnings if false).',
+            'Generate docs into the output directory (or only display warnings '
+            'if false).',
         negatable: true),
     DartdocOptionArgOnly<bool>('help', false, resourceProvider,
         abbr: 'h', help: 'Show command help.', negatable: false),
@@ -39,13 +41,13 @@ Future<DartdocProgramOptionContext> parseOptions(
   var optionSet = await DartdocOptionSet.fromOptionGenerators(
       'dartdoc',
       [
-        () => createDartdocOptions(packageMetaProvider),
-        () => createDartdocProgramOptions(packageMetaProvider.resourceProvider),
-        () => createLoggingOptions(packageMetaProvider.resourceProvider),
-        () => createGeneratorOptions(packageMetaProvider.resourceProvider),
+        createDartdocOptions,
+        createDartdocProgramOptions,
+        createLoggingOptions,
+        createGeneratorOptions,
         if (additionalOptions != null) additionalOptions,
       ],
-      packageMetaProvider.resourceProvider);
+      packageMetaProvider);
 
   try {
     optionSet.parseArguments(arguments);