Trying for logging again

Author: kevmoo

bin/dartdoc.dart

@@ -13,6 +13,7 @@ import 'package:analyzer/src/generated/sdk.dart';
 import 'package:args/args.dart';
 import 'package:dartdoc/dartdoc.dart';
 import 'package:dartdoc/src/logging.dart';
+import 'package:logging/logging.dart' as logging;
 import 'package:path/path.dart' as path;
 import 'package:stack_trace/stack_trace.dart';
 
@@ -121,29 +122,32 @@ main(List<String> arguments) async {
     _printUsageAndExit(parser, exitCode: 1);
   }
 
+  // By default, get all log output at `progressLevel` or greater.
+  // This allows us to capture progress events and print `...`.
+  logging.Logger.root.level = progressLevel;
   final stopwatch = new Stopwatch()..start();
 
   // Used to track if we're printing `...` to show progress.
   // Allows unified new-line tracking
   var writingProgress = false;
 
-  logEvents.listen((record) {
-    if (record.level == LogLevels.progress) {
-      if (showProgress &&
-          writingProgress &&
-          stopwatch.elapsed.inMilliseconds > 500) {
-        stdout.write('.');
+  logging.Logger.root.onRecord.listen((record) {
+    if (record.level == progressLevel) {
+      if (showProgress && stopwatch.elapsed.inMilliseconds > 250) {
+        writingProgress = true;
+        stderr.write('.');
         stopwatch.reset();
       }
       return;
     }
 
+    stopwatch.reset();
     if (writingProgress) {
       // print a new line after progress dots...
       print('');
       writingProgress = false;
     }
-    var message = record.message.toString();
+    var message = record.message;
     assert(message == message.trimRight());
     assert(message.isNotEmpty);
 

lib/src/logging.dart

@@ -2,29 +2,23 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:async';
+import 'package:logging/logging.dart';
 
-enum LogLevels { warning, info, progress }
+final _logger = new Logger('dartdoc');
 
-final _controller = new StreamController<LogMessage>(sync: true);
-
-Stream<LogMessage> get logEvents => _controller.stream;
-
-class LogMessage {
-  final LogLevels level;
-  final Object message;
-
-  LogMessage(this.level, this.message);
-}
+/// A custom [Level] for tracking file writes and verification.
+///
+/// Has a value of `501` – one more than [Level.FINE].
+final Level progressLevel = new Level('progress', 501);
 
 void logWarning(Object message) {
-  _controller.add(new LogMessage(LogLevels.warning, message));
+  _logger.log(Level.WARNING, message);
 }
 
 void logInfo(Object message) {
-  _controller.add(new LogMessage(LogLevels.info, message));
+  _logger.log(Level.INFO, message);
 }
 
 void logProgress(Object message) {
-  _controller.add(new LogMessage(LogLevels.progress, message));
+  _logger.log(progressLevel, message);
 }

pubspec.lock

@@ -350,4 +350,4 @@ packages:
     source: hosted
     version: "2.1.13"
 sdks:
-  dart: ">=1.23.0 <=2.0.0-dev.3.0"
+  dart: ">=1.23.0 <=2.0.0-dev.4.0"

pubspec.yaml

@@ -14,6 +14,7 @@ dependencies:
   # We don't use http_parser directly; this dep exists to ensure that we get at
   # least version 3.0.3 to work around an issue with 3.0.2.
   http_parser: '>=3.0.3 <4.0.0'
+  logging: ^0.11.3+1
   markdown: ^0.11.2
   mustache4dart: ^1.1.0
   package_config: '>=0.1.5 <2.0.0'