Skip to content

Commit b22cd23

Browse files
authored
Remove old lookup code and obliterate the tables that it depended on (#2765)
* Delete the lookup code itself * obliterate all the 'everything' tables that supported the old lookup code * dartfmt
1 parent a62e5f3 commit b22cd23

11 files changed

+140
-1084
lines changed

lib/src/dartdoc_options.dart

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,9 +1291,6 @@ class DartdocOptionContext extends DartdocOptionContextBase
12911291
List<String> get excludePackages =>
12921292
optionSet['excludePackages'].valueAt(context);
12931293

1294-
bool get enhancedReferenceLookup =>
1295-
optionSet['enhancedReferenceLookup'].valueAt(context);
1296-
12971294
String get flutterRoot => optionSet['flutterRoot'].valueAt(context);
12981295

12991296
bool get hideSdkText => optionSet['hideSdkText'].valueAt(context);
@@ -1427,17 +1424,6 @@ Future<List<DartdocOption>> createDartdocOptions(
14271424
help: 'Library names to ignore.', splitCommas: true),
14281425
DartdocOptionArgOnly<List<String>>('excludePackages', [], resourceProvider,
14291426
help: 'Package names to ignore.', splitCommas: true),
1430-
DartdocOptionArgFile<bool>(
1431-
'enhancedReferenceLookup', true, resourceProvider,
1432-
hide: true,
1433-
help:
1434-
'Use the new comment reference lookup system instead of the legacy '
1435-
'version. Please file a bug referencing this flag if you have to '
1436-
'change it to false -- this flag and associated behavior will '
1437-
'disappear in a future version.',
1438-
negatable: true),
1439-
// This could be a ArgOnly, but trying to not provide too many ways
1440-
// to set the flutter root.
14411427
DartdocOptionSyntheticOnly<String>(
14421428
'flutterRoot',
14431429
(DartdocSyntheticOption<String> option, Folder dir) => resourceProvider

lib/src/generator/templates.runtime_renderers.dart

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3357,20 +3357,6 @@ class _Renderer_Container extends RendererBase<Container> {
33573357
parent: r));
33583358
},
33593359
),
3360-
'allModelElementsByNamePart': Property(
3361-
getValue: (CT_ c) => c.allModelElementsByNamePart,
3362-
renderVariable: (CT_ c, Property<CT_> self,
3363-
List<String> remainingNames) =>
3364-
self.renderSimpleVariable(
3365-
c, remainingNames, 'Map<String, List<ModelElement>>'),
3366-
isNullValue: (CT_ c) => c.allModelElementsByNamePart == null,
3367-
renderValue: (CT_ c, RendererBase<CT_> r,
3368-
List<MustachioNode> ast, StringSink sink) {
3369-
renderSimple(
3370-
c.allModelElementsByNamePart, ast, r.template, sink,
3371-
parent: r, getters: _invisibleGetters['Map']);
3372-
},
3373-
),
33743360
'constantFields': Property(
33753361
getValue: (CT_ c) => c.constantFields,
33763362
renderVariable: (CT_ c, Property<CT_> self,
@@ -7460,19 +7446,6 @@ class _Renderer_Library extends RendererBase<Library> {
74607446
parent: r, getters: _invisibleGetters['HashMap']);
74617447
},
74627448
),
7463-
'modelElementsNameMap': Property(
7464-
getValue: (CT_ c) => c.modelElementsNameMap,
7465-
renderVariable: (CT_ c, Property<CT_> self,
7466-
List<String> remainingNames) =>
7467-
self.renderSimpleVariable(c, remainingNames,
7468-
'HashMap<String, Set<ModelElement>>'),
7469-
isNullValue: (CT_ c) => c.modelElementsNameMap == null,
7470-
renderValue: (CT_ c, RendererBase<CT_> r,
7471-
List<MustachioNode> ast, StringSink sink) {
7472-
renderSimple(c.modelElementsNameMap, ast, r.template, sink,
7473-
parent: r, getters: _invisibleGetters['HashMap']);
7474-
},
7475-
),
74767449
'name': Property(
74777450
getValue: (CT_ c) => c.name,
74787451
renderVariable:
@@ -14803,6 +14776,7 @@ const _invisibleGetters = {
1480314776
'DartType': {
1480414777
'hashCode',
1480514778
'runtimeType',
14779+
'alias',
1480614780
'aliasArguments',
1480714781
'aliasElement',
1480814782
'displayName',
@@ -14842,7 +14816,6 @@ const _invisibleGetters = {
1484214816
'examplePathPrefix',
1484314817
'exclude',
1484414818
'excludePackages',
14845-
'enhancedReferenceLookup',
1484614819
'flutterRoot',
1484714820
'hideSdkText',
1484814821
'include',
@@ -15112,6 +15085,7 @@ const _invisibleGetters = {
1511215085
'LibraryElement': {
1511315086
'hashCode',
1511415087
'runtimeType',
15088+
'accessibleExtensions',
1511515089
'definingCompilationUnit',
1511615090
'entryPoint',
1511715091
'exportedLibraries',
@@ -15239,7 +15213,6 @@ const _invisibleGetters = {
1523915213
'implementors',
1524015214
'documentedExtensions',
1524115215
'extensions',
15242-
'findRefElementCache',
1524315216
'defaultPackageName',
1524415217
'defaultPackage',
1524515218
'hasFooterVersion',

0 commit comments

Comments
 (0)