Skip to content

Commit 8dee2ba

Browse files
committed
Fix long-skipped test
1 parent 1c2cc1d commit 8dee2ba

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

test/model_test.dart

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -461,17 +461,10 @@ void main() {
461461

462462
test('links to a top-level variable with a prefix from an imported lib',
463463
() {
464-
expect(docsAsHtml,
465-
contains('<a href="">css.theOnlyThingInTheLibrary</a>'));
466-
},
467-
skip:
468-
'Wait for https://github.com/dart-lang/dartdoc/issues/767 to be fixed');
469-
470-
// remove this test when the above test is fixed. just here to
471-
// track when the behavior changes
472-
test('codeifies a prefixed top-level variable an imported lib', () {
473464
expect(
474-
docsAsHtml, contains('<code>css.theOnlyThingInTheLibrary</code>'));
465+
docsAsHtml,
466+
contains(
467+
'<a href="ex/incorrectDocReferenceFromEx-constant.html">example_prefixed.incorrectDocReferenceFromEx</a>'));
475468
});
476469

477470
test('links to a name with a single underscore', () {

testing/test_package/lib/fake.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ import 'dart:collection';
5252

5353
import 'example.dart';
5454

55-
import 'css.dart' as css;
55+
import 'example.dart' as example_prefixed;
5656

5757
import 'two_exports.dart' show BaseClass;
5858

@@ -496,7 +496,7 @@ class BaseForDocComments {
496496
///
497497
/// Reference to a top-level const in another library [incorrectDocReferenceFromEx]
498498
///
499-
/// Reference to prefixed-name from another lib [css.theOnlyThingInTheLibrary] xx
499+
/// Reference to prefixed-name from another lib [example_prefixed.incorrectDocReferenceFromEx]
500500
///
501501
/// Reference to a name that exists in this package, but is not imported
502502
/// in this library [doesStuff] xx

testing/test_package_docs/fake/BaseForDocComments/doAwesomeStuff.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ <h5>class BaseForDocComments</h5>
8080
<p>Reference to a top-level const in this library that shares the same
8181
name as a top-level name in another library <a href="fake/incorrectDocReference-constant.html">incorrectDocReference</a> xx</p>
8282
<p>Reference to a top-level const in another library <a href="ex/incorrectDocReferenceFromEx-constant.html">incorrectDocReferenceFromEx</a></p>
83-
<p>Reference to prefixed-name from another lib <a href="css/theOnlyThingInTheLibrary.html">css.theOnlyThingInTheLibrary</a> xx</p>
83+
<p>Reference to prefixed-name from another lib <a href="ex/incorrectDocReferenceFromEx-constant.html">example_prefixed.incorrectDocReferenceFromEx</a></p>
8484
<p>Reference to a name that exists in this package, but is not imported
8585
in this library <a href="anonymous_library/doesStuff.html">doesStuff</a> xx</p>
8686
<p>Reference to a name of a class from an import of a library that exported

0 commit comments

Comments
 (0)