Tidy tidy tidy

Author: srawlins

analysis_options.yaml

@@ -6,7 +6,6 @@ analyzer:
   errors:
     unused_import: warning
     unused_shown_name: warning
-    todo: ignore
   exclude:
     - 'doc/**'
     - 'lib/src/third_party/pkg/**'

lib/src/model/package_builder.dart

@@ -169,17 +169,9 @@ class PubPackageBuilder implements PackageBuilder {
       // TODO(jcollins-g): Make use of currently not existing API for managing
       //                   many AnalysisDrivers
       // TODO(jcollins-g): make use of DartProject isApi()
-      _driver = AnalysisDriver(
-        scheduler,
-        log,
-        resourceProvider,
-        MemoryByteStore(),
-        FileContentOverlay(),
-        null,
-        sourceFactory,
-        options,
-        packages: Packages.empty,
-      );
+      _driver = AnalysisDriver(scheduler, log, resourceProvider,
+          MemoryByteStore(), FileContentOverlay(), null, sourceFactory, options,
+          packages: Packages.empty);
       driver.results.listen((_) => logProgress(''));
       driver.exceptions.listen((_) {});
       scheduler.start();

lib/src/package_meta.dart

@@ -185,9 +185,6 @@ abstract class PubPackageMeta extends PackageMeta {
       _sdkDirParent[dirPathCanonical] = null;
       while (dir.exists) {
         if (_sdkDirFilePaths.every((List<String> l) {
-          var path = pathContext.join(dir.path, l.last);
-          print('checking ${dir.path} for $l: does $path exist? '
-              '${resourceProvider.getFile(path).exists}');
           return l.any((f) =>
               resourceProvider.getFile(pathContext.join(dir.path, f)).exists);
         })) {

pubspec.yaml

@@ -19,7 +19,7 @@ dependencies:
   logging: ^0.11.3+1
   process: ^3.0.5
   markdown: ^2.1.5
-  meta: ^1.2.3
+  meta: ^1.1.8
   mustache: ^1.1.0
   package_config: '>=0.1.5 <2.0.0'
   path: ^1.3.0
@@ -43,4 +43,4 @@ dev_dependencies:
   test: ^1.3.0
 
 executables:
-  dartdoc: null
+  dartdoc: null

test/comment_processable_test.dart

@@ -38,7 +38,6 @@ void main() {
         .writeAsStringSync('''
 name: foo
 ''');
-    //var sdk = MockSdk(resourceProvider: resourceProvider);
     var packageMetaProvider = PackageMetaProvider(
       PubPackageMeta.fromElement,
       PubPackageMeta.fromFilename,