Skip to content

Commit 1035a97

Browse files
committed
Move initEmptyGenerators
1 parent ab6abf4 commit 1035a97

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

lib/dartdoc.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import 'dart:convert';
1313
import 'dart:io';
1414

1515
import 'package:dartdoc/src/dartdoc_options.dart';
16+
import 'package:dartdoc/src/empty_generator.dart';
1617
import 'package:dartdoc/src/generator.dart';
1718
import 'package:dartdoc/src/html/html_generator.dart';
1819
import 'package:dartdoc/src/logging.dart';
@@ -36,8 +37,7 @@ const String programName = 'dartdoc';
3637
// Update when pubspec version changes by running `pub run build_runner build`
3738
const String dartdocVersion = packageVersion;
3839

39-
/// Helper class to initialize the default generators since they require
40-
/// GeneratorContext.
40+
/// Helper class that consolidates option contexts for instantiating generators.
4141
class DartdocGeneratorOptionContext extends DartdocOptionContext
4242
with BaseGeneratorContext, HtmlGeneratorContext {
4343
DartdocGeneratorOptionContext(DartdocOptionSet optionSet, Directory dir)
@@ -64,7 +64,7 @@ class Dartdoc extends PackageBuilder {
6464
/// and returns a Dartdoc object with them.
6565
static Future<Dartdoc> withDefaultGenerators(
6666
DartdocGeneratorOptionContext config) async {
67-
List<Generator> generators = await initGenerators(config);
67+
List<Generator> generators = await initHtmlGenerators(config);
6868
return Dartdoc._(config, generators);
6969
}
7070

lib/src/empty_generator.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ library dartdoc.empty_generator;
22

33
import 'dart:async';
44

5+
import 'package:dartdoc/src/dartdoc_options.dart';
56
import 'package:dartdoc/src/generator.dart';
67
import 'package:dartdoc/src/model/model.dart';
78
import 'package:dartdoc/src/model_utils.dart';
@@ -38,3 +39,7 @@ class EmptyGenerator extends Generator {
3839
@override
3940
Set<String> get writtenFiles => Set();
4041
}
42+
43+
Future<List<Generator>> initEmptyGenerators(DartdocOptionContext config) async {
44+
return [EmptyGenerator()];
45+
}

lib/src/html/html_generator.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,8 @@ class HtmlGeneratorOptions implements HtmlOptions {
140140
: this.toolVersion = toolVersion ?? 'unknown';
141141
}
142142

143-
Future<List<Generator>> initEmptyGenerators(DartdocOptionContext config) async {
144-
return [EmptyGenerator()];
145-
}
146-
147143
/// Initialize and setup the generators.
148-
Future<List<Generator>> initGenerators(
144+
Future<List<Generator>> initHtmlGenerators(
149145
DartdocGeneratorOptionContext config) async {
150146
// TODO(jcollins-g): Rationalize based on GeneratorContext all the way down
151147
// through the generators.

0 commit comments

Comments
 (0)