Review comments

jcollins-g · jcollins-g · commit 102090e2b4a8 · 2019-01-31T08:05:25.000-08:00
diff --git a/lib/src/model.dart b/lib/src/model.dart
@@ -3216,12 +3216,10 @@ abstract class ModelElement extends Canonicalization
     return _documentationFrom;
   }
 
-  bool get hasSourceHref => sourceHref != '';
+  bool get hasSourceHref => sourceHref.isNotEmpty;
   String _sourceHref;
   String get sourceHref {
-    if (_sourceHref == null) {
-      _sourceHref = new SourceLinker.fromElement(this).href();
-    }
+    _sourceHref ??= new SourceLinker.fromElement(this).href();
     return _sourceHref;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -3216,12 +3216,10 @@ abstract class ModelElement extends Canonicalization`
`3216`	`3216`	`return _documentationFrom;`
`3217`	`3217`	`}`
`3218`	`3218`
`3219`		`- bool get hasSourceHref => sourceHref != '';`
	`3219`	`+ bool get hasSourceHref => sourceHref.isNotEmpty;`
`3220`	`3220`	`String _sourceHref;`
`3221`	`3221`	`String get sourceHref {`
`3222`		`- if (_sourceHref == null) {`
`3223`		`- _sourceHref = new SourceLinker.fromElement(this).href();`
`3224`		`- }`
	`3222`	`+ _sourceHref ??= new SourceLinker.fromElement(this).href();`
`3225`	`3223`	`return _sourceHref;`
`3226`	`3224`	`}`
`3227`	`3225`