verify substring problem is fixed

Author: jcollins-g

test/model_test.dart

@@ -718,7 +718,7 @@ void main() {
     });
 
     test('correctly finds all the classes', () {
-      expect(classes, hasLength(26));
+      expect(classes, hasLength(28));
     });
 
     test('abstract', () {
@@ -1849,7 +1849,7 @@ String topLevelFunction(int param1, bool param2, Cool coolBeans,
         prettyColorsConstant,
         deprecated;
 
-    Field aStaticConstField;
+    Field aStaticConstField, aName;
 
     setUp(() {
       greenConstant =
@@ -1861,9 +1861,16 @@ String topLevelFunction(int param1, bool param2, Cool coolBeans,
       cat = exLibrary.constants.firstWhere((c) => c.name == 'MY_CAT');
       deprecated =
           exLibrary.constants.firstWhere((c) => c.name == 'deprecated');
+      Class Dog = exLibrary.allClasses.firstWhere((c) => c.name == 'Dog');
       aStaticConstField =
-          exLibrary.allClasses.firstWhere((c) => c.name == 'Dog')
-              .allFields.firstWhere((f) => f.name == 'aStaticConstField');
+              Dog.allFields.firstWhere((f) => f.name == 'aStaticConstField');
+      aName =
+          Dog.allFields.firstWhere((f) => f.name == 'aName');
+    });
+
+    test('substrings of the constant values type are not linked (#1535)', () {
+      expect(aName.constantValue,
+          'const ExtendedShortName("hello there")');
     });
 
     test('constant field values are escaped', () {

testing/test_package/lib/example.dart

@@ -94,6 +94,15 @@ class TemplatedClass<X> {
   }
 }
 
+class ShortName {
+  final String aParameter;
+  const ShortName(this.aParameter);
+}
+
+class ExtendedShortName extends ShortName {
+  const ExtendedShortName(String aParameter) : super(aParameter);
+}
+
 /// Referencing [processMessage] (or other things) here should not break
 /// enum constants ala #1445
 enum Animal {
@@ -273,6 +282,9 @@ class Dog implements Cat, E {
   final int aFinalField;
   static const String aStaticConstField = "A Constant Dog";
 
+  /// Verify link substitution in constants (#1535)
+  static const ShortName aName = const ExtendedShortName("hello there");
+
   @protected
   final int aProtectedFinalField;