-
Notifications
You must be signed in to change notification settings - Fork 23
Add enable_null_safety
to core
#790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
CC @bwilkerson @pq as I think this is the only diagnostic which can report a |
SGTM. /fyi @natebosch @jakemac53 @mit-mit @lrhn @goderbauer @munificent |
If we make the |
I don't see anything wrong with keeping the minimum SDK version at 2.17.0. |
FYI that we've since increased the min. required sdk here to 3.0, so if we do want this to resolve into a pre-3.0 sdk, we'd need to publish a release off the commit for |
I don't think it's worth a backpublish for this. I think we should close this. |
From a discussion, this would have been useful to add a few SDK releases ago, but will add little to no value at this point. Closing. |
This rule: https://dart-lang.github.io/linter/lints/enable_null_safety.html
I propose we add it to a lints release that supports Dart 2.x, so that users can see if they have any pre-null safety files they forgot about, before using Dart 3.0 (like tests, tools, etc).
The text was updated successfully, but these errors were encountered: