Skip to content

Add enable_null_safety to core #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srawlins opened this issue Jan 4, 2023 · 7 comments
Closed

Add enable_null_safety to core #790

srawlins opened this issue Jan 4, 2023 · 7 comments

Comments

@srawlins
Copy link
Member

srawlins commented Jan 4, 2023

This rule: https://dart-lang.github.io/linter/lints/enable_null_safety.html

I propose we add it to a lints release that supports Dart 2.x, so that users can see if they have any pre-null safety files they forgot about, before using Dart 3.0 (like tests, tools, etc).

@srawlins
Copy link
Member Author

srawlins commented Jan 4, 2023

CC @bwilkerson @pq as I think this is the only diagnostic which can report a // @dart=2.9 language version override in Dart 2.19.

@pq
Copy link
Member

pq commented Jan 6, 2023

@lrhn
Copy link
Member

lrhn commented Jan 10, 2023

If we make the lints package require SDK 2.19, it should not unduly affect code that still uses older SDKs.
Would we want that?

@srawlins
Copy link
Member Author

I don't see anything wrong with keeping the minimum SDK version at 2.17.0.

@devoncarew
Copy link
Member

FYI that we've since increased the min. required sdk here to 3.0, so if we do want this to resolve into a pre-3.0 sdk, we'd need to publish a release off the commit for package:lints v2.0.1.

@natebosch
Copy link
Member

I don't think it's worth a backpublish for this. I think we should close this.

@devoncarew
Copy link
Member

From a discussion, this would have been useful to add a few SDK releases ago, but will add little to no value at this point. Closing.

@mosuem mosuem transferred this issue from dart-archive/lints Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants