Skip to content

Commit 7a964f3

Browse files
committed
Hacking.
1 parent 13f0132 commit 7a964f3

File tree

19 files changed

+41
-20
lines changed

19 files changed

+41
-20
lines changed

_test_common/lib/in_memory_reader_writer.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class InMemoryRunnerAssetReaderWriter extends InMemoryAssetReaderWriterImpl
2828

2929
@override
3030
Future writeAsBytes(AssetId id, List<int> bytes) async {
31-
var type = assets.containsKey(id) ? ChangeType.MODIFY : ChangeType.ADD;
31+
var type = testing.exists(id) ? ChangeType.MODIFY : ChangeType.ADD;
3232
await super.writeAsBytes(id, bytes);
3333
FakeWatcher.notifyWatchers(
3434
WatchEvent(type, p.absolute(id.package, p.fromUri(id.path))),
@@ -41,7 +41,7 @@ class InMemoryRunnerAssetReaderWriter extends InMemoryAssetReaderWriterImpl
4141
String contents, {
4242
Encoding encoding = utf8,
4343
}) async {
44-
var type = assets.containsKey(id) ? ChangeType.MODIFY : ChangeType.ADD;
44+
var type = testing.exists(id) ? ChangeType.MODIFY : ChangeType.ADD;
4545
await super.writeAsString(id, contents, encoding: encoding);
4646
FakeWatcher.notifyWatchers(
4747
WatchEvent(type, p.absolute(id.package, p.fromUri(id.path))),

build/lib/src/builder/build_step_impl.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ class BuildStepImpl implements BuildStep, AssetReaderState {
100100
@override
101101
Filesystem get filesystem => _reader.filesystem;
102102

103+
@override
104+
FilesystemCache get cache => _reader.cache;
105+
103106
@override
104107
AssetFinder get assetFinder => _reader.assetFinder;
105108

build/lib/src/state/reader_state.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ extension AssetReaderStateExtension on AssetReader {
2222
return (this as AssetReaderState).filesystem;
2323
}
2424

25+
FilesystemCache get cache {
26+
_requireIsAssetReaderState();
27+
return (this as AssetReaderState).cache;
28+
}
29+
2530
AssetFinder get assetFinder {
2631
_requireIsAssetReaderState();
2732
return (this as AssetReaderState).assetFinder;
@@ -68,6 +73,9 @@ abstract interface class AssetReaderState {
6873
/// such as read tracking, caching and visibility restriction.
6974
Filesystem get filesystem;
7075

76+
/// The [FilesystemCache] that this reader uses for caching.
77+
FilesystemCache get cache;
78+
7179
/// The [AssetFinder] associated with this reader.
7280
///
7381
/// All readers have an [AssetFinder], but the functionality it provides,

build/test/builder/build_step_impl_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ void main() {
113113
await buildStep.complete();
114114

115115
// One output.
116-
expect(readerWriter.readStringForTest(outputId), 'foo');
116+
expect(readerWriter.testing.readString(outputId), 'foo');
117117
});
118118

119119
group('resolve', () {

build/test/generate/run_post_process_builder_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ void main() {
6363
addAsset: addAsset,
6464
deleteAsset: deleteAsset,
6565
);
66-
expect(readerWriter.existsForTest(aTxt), isTrue);
67-
expect(readerWriter.readStringForTest(aTxtCopy), 'a');
66+
expect(readerWriter.testing.exists(aTxt), isTrue);
67+
expect(readerWriter.testing.readString(aTxtCopy), 'a');
6868
expect(adds, contains(aTxtCopy));
6969
});
7070

build_runner/lib/src/watcher/change_filter.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ FutureOr<bool> shouldProcess(
3131
if (_isAddOrEditOnGeneratedFile(node, change.type)) return false;
3232
if (change.type == ChangeType.MODIFY) {
3333
// Was it really modified or just touched?
34-
reader.filesystem.cache.invalidate([change.id]);
34+
reader.cache.invalidate([change.id]);
3535
return reader
3636
.digest(change.id)
3737
.then((newDigest) => node.lastKnownDigest != newDigest);

build_runner/test/server/asset_handler_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ void main() {
5050
node.deletedBy.add(node.id.addExtension('.post_anchor.1'));
5151
}
5252
graph.add(node);
53-
delegate.filesystem.writeAsStringSync(node.id, content);
53+
delegate.testing.writeString(node.id, content);
5454
}
5555

5656
test('can not read deleted nodes', () async {

build_runner_core/lib/src/asset/batch.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ final class BatchReader extends AssetReader implements AssetReaderState {
8787
@override
8888
Filesystem get filesystem => _inner.filesystem;
8989

90+
@override
91+
FilesystemCache get cache => _inner.cache;
92+
9093
@override
9194
AssetPathProvider? get assetPathProvider => _inner.assetPathProvider;
9295

build_runner_core/lib/src/asset/build_cache.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ class BuildCacheReader implements AssetReader, AssetReaderState {
4747
@override
4848
Filesystem get filesystem => _delegate.filesystem;
4949

50+
@override
51+
FilesystemCache get cache => _delegate.cache;
52+
5053
@override
5154
AssetFinder get assetFinder => _delegate.assetFinder;
5255

build_runner_core/lib/src/asset/file_based.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ class FileBasedAssetReader extends AssetReader implements AssetReaderState {
2424
final Filesystem filesystem;
2525
@override
2626
late final AssetFinder assetFinder = FunctionAssetFinder(_findAssets);
27-
27+
@override
2828
final FilesystemCache cache;
29+
2930
final PackageGraph packageGraph;
3031

3132
FileBasedAssetReader(

build_runner_core/lib/src/asset/reader.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,9 @@ class SingleStepReader extends AssetReader implements AssetReaderState {
106106
@override
107107
Filesystem get filesystem => _delegate.filesystem;
108108

109+
@override
110+
FilesystemCache get cache => _delegate.cache;
111+
109112
@override
110113
AssetPathProvider? get assetPathProvider => _delegate.assetPathProvider;
111114

build_runner_core/lib/src/asset_graph/graph.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ class AssetGraph {
190190
Iterable<AssetNode> nodes,
191191
AssetReader digestReader,
192192
) async {
193-
await digestReader.filesystem.cache.invalidate(nodes.map((n) => n.id));
193+
await digestReader.cache.invalidate(nodes.map((n) => n.id));
194194
await Future.wait(
195195
nodes.map((node) async {
196196
node.lastKnownDigest = await digestReader.digest(node.id);

build_runner_core/lib/src/generate/build_definition.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ class AssetTracker {
168168
var node = assetGraph.get(id)!;
169169
var originalDigest = node.lastKnownDigest;
170170
if (originalDigest == null) return;
171-
await _reader.filesystem.cache.invalidate([id]);
171+
await _reader.cache.invalidate([id]);
172172
var currentDigest = await _reader.digest(id);
173173
if (currentDigest != originalDigest) {
174174
updates[id] = ChangeType.MODIFY;

build_runner_core/lib/src/generate/build_impl.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ class _SingleBuild {
296296
_delete,
297297
_reader,
298298
);
299-
await _reader.filesystem.cache.invalidate(invalidated);
299+
await _reader.cache.invalidate(invalidated);
300300
});
301301
}
302302

@@ -978,7 +978,7 @@ class _SingleBuild {
978978
return;
979979
} else {
980980
if (node.lastKnownDigest == null) {
981-
await reader.filesystem.cache.invalidate([id]);
981+
await reader.cache.invalidate([id]);
982982
node.lastKnownDigest = await reader.digest(id);
983983
}
984984
}

build_runner_core/test/environment/create_merged_dir_test.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void main() {
7070
setUp(() async {
7171
readerWriter = InMemoryRunnerAssetReaderWriter();
7272
for (final source in sources.entries) {
73-
readerWriter.filesystem.writeAsStringSync(source.key, source.value);
73+
readerWriter.testing.writeString(source.key, source.value);
7474
}
7575
environment = TestBuildEnvironment(readerWriter: readerWriter);
7676
graph = await AssetGraph.build(
@@ -102,10 +102,7 @@ void main() {
102102
..state = NodeState.upToDate
103103
..wasOutput = true
104104
..isFailure = false;
105-
readerWriter.filesystem.writeAsStringSync(
106-
id,
107-
sources[node.primaryInput]!,
108-
);
105+
readerWriter.testing.writeString(id, sources[node.primaryInput]!);
109106
}
110107
tmpDir = await Directory.systemTemp.createTemp('build_tests');
111108
anotherTmpDir = await Directory.systemTemp.createTemp('build_tests');

build_test/lib/src/in_memory_reader_writer.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ class InMemoryAssetReaderWriterImpl extends AssetReader
6161

6262
final InMemoryFilesystem _filesystem;
6363

64+
@override
6465
final FilesystemCache cache;
6566

6667
final String? rootPackage;

build_test/lib/src/written_asset_reader.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ class WrittenAssetReader extends AssetReader implements AssetReaderState {
3333
@override
3434
Filesystem get filesystem => source.filesystem;
3535

36+
@override
37+
FilesystemCache get cache => source.cache;
38+
3639
@override
3740
late final AssetFinder assetFinder = FunctionAssetFinder(_findAssets);
3841

@@ -52,7 +55,7 @@ class WrittenAssetReader extends AssetReader implements AssetReaderState {
5255

5356
@override
5457
Future<bool> canRead(AssetId id) {
55-
var canRead = source.existsForTest(id);
58+
var canRead = source.testing.exists(id);
5659
if (filterSpy != null) {
5760
canRead =
5861
canRead &&

build_web_compilers/test/util.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ Future<void> testBuilderAndCollectAssets(
1717
builder,
1818
assets,
1919
onLog: (log) => printOnFailure('${log.level}: ${log.message}'),
20-
resumeFrom:
2120
);
2221
result.readerWriter.assets.forEach((id, value) {
2322
assets['${id.package}|${id.path}'] = value;

scratch_space/test/scratch_space_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ void main() {
9393
var writer = InMemoryAssetReaderWriter();
9494
await scratchSpace.copyOutput(outputId, writer);
9595

96-
expect(writer.readStringForTest(outputId), outputContent);
96+
expect(writer.testing.readString(outputId), outputContent);
9797
});
9898

9999
test('Can delete a ScratchSpace', () async {

0 commit comments

Comments
 (0)