Remove batch writes.

Author: davidmorgan

_test_common/lib/matchers.dart

@@ -189,9 +189,10 @@ class _AssetGraphMatcher extends Matcher {
         }
       }
     }
-    if (!equals(
-      _expected.packageLanguageVersions,
-    ).matches(item.packageLanguageVersions, matchState)) {
+    if (!equals(_expected.packageLanguageVersions).matches(
+      item.packageLanguageVersions,
+      matchState['packageLanguageVersions'] = <String, LanguageVersion?>{},
+    )) {
       matches = false;
     }
     return matches;

build/lib/src/state/reader_state.dart

@@ -41,6 +41,11 @@ extension AssetReaderStateExtension on AssetReader {
   InputTracker? get inputTracker =>
       this is AssetReaderState ? (this as AssetReaderState).inputTracker : null;
 
+  AssetPathProvider get assetPathProvider {
+    _requireIsAssetReaderState();
+    return (this as AssetReaderState).assetPathProvider;
+  }
+
   /// Gets [inputTracker] or throws a descriptive error if it is `null`.
   InputTracker get requireInputTracker {
     final result = inputTracker;
@@ -53,11 +58,6 @@ extension AssetReaderStateExtension on AssetReader {
     return result;
   }
 
-  AssetPathProvider get assetPathProvider {
-    _requireIsAssetReaderState();
-    return (this as AssetReaderState).assetPathProvider;
-  }
-
   /// Throws if `this` is not an [AssetReaderState].
   void _requireIsAssetReaderState() {
     if (this is! AssetReaderState) {

build_runner_core/lib/build_runner_core.dart

@@ -4,7 +4,6 @@
 
 export 'package:build/build.dart' show PostProcessBuildStep, PostProcessBuilder;
 
-export 'src/asset/batch.dart' show wrapInBatch;
 export 'src/asset/file_based.dart';
 export 'src/asset/finalized_reader.dart';
 export 'src/asset/writer.dart';

build_runner_core/lib/src/asset/batch.dart

@@ -68,24 +68,19 @@ class BuildCacheWriter implements RunnerAssetWriter {
 }
 
 AssetId _cacheLocation(AssetId id, AssetGraph assetGraph, String rootPackage) {
-  print('_cacheLocation $id');
   if (id.path.startsWith(generatedOutputDirectory) ||
       id.path.startsWith(cacheDir)) {
-    print('--> return 1');
     return id;
   }
   if (!assetGraph.contains(id)) {
-    print('--> return 2');
     return id;
   }
   final assetNode = assetGraph.get(id);
   if (assetNode is GeneratedAssetNode && assetNode.isHidden) {
-    print('--> hit');
     return AssetId(
       rootPackage,
       '$generatedOutputDirectory/${id.package}/${id.path}',
     );
   }
-  print('--> return 3');
   return id;
 }

build_runner_core/lib/src/asset/build_cache.dart

@@ -13,7 +13,6 @@ import 'package:glob/list_local_fs.dart';
 import 'package:path/path.dart' as path;
 
 import '../package_graph/package_graph.dart';
-import 'build_cache.dart';
 import 'writer.dart';
 
 /// Basic [AssetReader] which uses a [PackageGraph] to look up where to read
@@ -71,9 +70,6 @@ class FileBasedAssetReader extends AssetReader implements AssetReaderState {
       ifAbsent: () async {
         final path = assetPathProvider.pathFor(id);
         if (!await filesystem.exists(path)) {
-          print(
-            '${assetPathProvider.runtimeType} is missing $path at ${StackTrace.current}',
-          );
           throw AssetNotFoundException(id, path: path);
         }
         return filesystem.readAsBytes(path);
@@ -89,7 +85,6 @@ class FileBasedAssetReader extends AssetReader implements AssetReaderState {
       ifAbsent: () async {
         final path = assetPathProvider.pathFor(id);
         if (!await filesystem.exists(path)) {
-          print('${assetPathProvider.runtimeType} is missing $path');
           throw AssetNotFoundException(id, path: path);
         }
         return filesystem.readAsBytes(path);
@@ -165,5 +160,7 @@ class FileBasedAssetWriter implements RunnerAssetWriter {
   }
 
   @override
-  Future<void> completeBuild() async {}
+  Future<void> completeBuild() async {
+    // TODO(davidmorgan): add back write caching, "batching".
+  }
 }

build_runner_core/lib/src/asset/file_based.dart

@@ -8,7 +8,6 @@ import 'dart:io';
 import 'package:build/build.dart';
 import 'package:logging/logging.dart';
 
-import '../asset/batch.dart';
 import '../asset/file_based.dart';
 import '../asset/writer.dart';
 import '../generate/build_directory.dart';
@@ -46,7 +45,6 @@ class IOEnvironment implements BuildEnvironment {
     PackageGraph packageGraph, {
     bool? assumeTty,
     bool outputSymlinksOnly = false,
-    //bool lowResourcesMode = false,
   }) {
     if (outputSymlinksOnly && Platform.isWindows) {
       _logger.warning(
@@ -56,17 +54,9 @@ class IOEnvironment implements BuildEnvironment {
       );
     }
 
-    var fileReader = FileBasedAssetReader(packageGraph);
-    var fileWriter = FileBasedAssetWriter(packageGraph);
-
-    var (reader, writer) =
-        true
-            ? (fileReader, fileWriter)
-            : wrapInBatch(reader: fileReader, writer: fileWriter);
-
     return IOEnvironment._(
-      reader,
-      writer,
+      FileBasedAssetReader(packageGraph),
+      FileBasedAssetWriter(packageGraph),
       assumeTty == true || _canPrompt(),
       outputSymlinksOnly,
       packageGraph,

build_runner_core/lib/src/environment/io_environment.dart

@@ -1023,6 +1023,9 @@ class _SingleBuild {
 
     for (var output in outputs) {
       var wasOutput = writer.assetsWritten.contains(output);
+      if (wasOutput) {
+        await _reader.digest(output);
+      }
       var digest = wasOutput ? await _reader.digest(output) : null;
       var node = _assetGraph.get(output) as GeneratedAssetNode;