Properly map function names with named arguments.

[email protected]

Review URL: https://codereview.chromium.org//2069043004 .

Author: nex3

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.5
+
+* Add compatibility for member names that include named arguments.
+
 ## 1.0.4
 
 * Add compatibility for Dart 1.10-style name munging.

lib/source_map_stack_trace.dart

@@ -84,8 +84,8 @@ String _prettifyMember(String member) {
   return member
       // Get rid of the noise that Firefox sometimes adds.
       .replaceAll(new RegExp(r"/?<$"), "")
-      // Get rid of arity indicators.
-      .replaceAll(new RegExp(r"\$\d+$"), "")
+      // Get rid of arity indicators and named arguments.
+      .replaceAll(new RegExp(r"\$\d+(\$[a-zA-Z_0-9]+)*$"), "")
       // Convert closures to <fn>.
       .replaceAllMapped(new RegExp(r"(_+)closure\d*\.call$"),
           // The number of underscores before "closure" indicates how nested it

pubspec.yaml

@@ -1,5 +1,5 @@
 name: source_map_stack_trace
-version: 1.0.4
+version: 1.0.5
 description: >
   A package for applying source maps to stack traces.
 author: Dart Team <[email protected]>

test/source_map_stack_trace_test.dart

@@ -153,6 +153,11 @@ foo.dart.js 10:11  baz
       expect(_prettify(r"foo$1234"), equals("foo"));
     });
 
+    test("named arguments", () {
+      expect(_prettify(r"foo$1$bar"), equals("foo"));
+      expect(_prettify(r"foo$123$bar$bang$qux"), equals("foo"));
+    });
+
     test("closures", () {
       expect(_prettify("foo_closure.call"), equals("foo.<fn>"));
     });