Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Commit cecbdb3

Browse files
authored
enhanced enums tests for unnecessary_overrides (#3187)
* enhanced enums tests for `unnecessary_overrides` * fmt
1 parent fc1f1fd commit cecbdb3

File tree

2 files changed

+52
-0
lines changed

2 files changed

+52
-0
lines changed

test/rules/all.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ import 'tighten_type_of_initializing_formals.dart'
4545
import 'type_init_formals.dart' as type_init_formals;
4646
import 'unawaited_futures.dart' as unawaited_futures;
4747
import 'unnecessary_null_checks.dart' as unnecessary_null_checks;
48+
import 'unnecessary_overrides.dart' as unnecessary_overrides;
4849
import 'use_is_even_rather_than_modulo.dart' as use_is_even_rather_than_modulo;
4950
import 'void_checks.dart' as void_checks;
5051

@@ -80,6 +81,7 @@ void main() {
8081
type_init_formals.main();
8182
unawaited_futures.main();
8283
unnecessary_null_checks.main();
84+
unnecessary_overrides.main();
8385
use_is_even_rather_than_modulo.main();
8486
void_checks.main();
8587
}

test/rules/unnecessary_overrides.dart

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
2+
// for details. All rights reserved. Use of this source code is governed by a
3+
// BSD-style license that can be found in the LICENSE file.
4+
5+
import 'package:test_reflective_loader/test_reflective_loader.dart';
6+
7+
import '../rule_test_support.dart';
8+
9+
main() {
10+
defineReflectiveSuite(() {
11+
defineReflectiveTests(UnnecessaryOverridesTest);
12+
});
13+
}
14+
15+
@reflectiveTest
16+
class UnnecessaryOverridesTest extends LintRuleTest {
17+
@override
18+
List<String> get experiments => [
19+
EnableString.enhanced_enums,
20+
];
21+
22+
@override
23+
String get lintRule => 'unnecessary_overrides';
24+
25+
@FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3097')
26+
test_field() async {
27+
await assertDiagnostics(r'''
28+
enum A {
29+
a,b,c;
30+
@override
31+
int get foo => 0;
32+
}
33+
''', [
34+
lint('unnecessary_overrides', 28, 8),
35+
]);
36+
}
37+
38+
@FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3097')
39+
test_method() async {
40+
await assertDiagnostics(r'''
41+
enum A {
42+
a,b,c;
43+
@override
44+
String bar() => '';
45+
}
46+
''', [
47+
lint('unnecessary_overrides', 27, 8),
48+
]);
49+
}
50+
}

0 commit comments

Comments
 (0)