Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Commit 634f723

Browse files
authored
Fix false negative in avoid_positional_boolean_parameters (#2832)
* Fix false negative in `avoid_positional_boolean_parameters` * use `checkParams`
1 parent acd9b7b commit 634f723

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

lib/src/rules/avoid_positional_boolean_parameters.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class AvoidPositionalBooleanParameters extends LintRule {
6060
registry.addConstructorDeclaration(this, visitor);
6161
registry.addFunctionDeclaration(this, visitor);
6262
registry.addMethodDeclaration(this, visitor);
63+
registry.addGenericFunctionType(this, visitor);
6364
}
6465
}
6566

@@ -105,6 +106,11 @@ class _Visitor extends SimpleAstVisitor<void> {
105106
}
106107
}
107108

109+
@override
110+
void visitGenericFunctionType(GenericFunctionType node) {
111+
checkParams(node.parameters.parameters);
112+
}
113+
108114
bool _isOverridingMember(Element member) {
109115
var classElement = member.thisOrAncestorOfType<ClassElement>();
110116
if (classElement == null) return false;

test_data/rules/avoid_positional_boolean_parameters.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,3 +101,7 @@ extension Ext on E {
101101
extension on E {
102102
void badBadBad([bool value = false]) {} // LINT
103103
}
104+
105+
typedef J = Function({bool value}); // OK
106+
107+
typedef K = Function(bool value); // LINT

0 commit comments

Comments
 (0)