Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Commit 36e9209

Browse files
committed
Merge pull request #67 from dart-lang/fix_64
Exclude getters/setters from one_member_abstracts lint. Fix #64.
2 parents 1859b6b + 8608332 commit 36e9209

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/src/rules/one_member_abstracts.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ class Visitor extends SimpleAstVisitor {
5555
node.extendsClause == null &&
5656
node.members.length == 1) {
5757
var member = node.members[0];
58-
if (member is MethodDeclaration && member.isAbstract) {
58+
if (member is MethodDeclaration &&
59+
member.isAbstract &&
60+
!member.isGetter &&
61+
!member.isSetter) {
5962
rule.reportLint(node.name);
6063
}
6164
}

test/rules/one_member_abstracts.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,7 @@ abstract class Z extends X {
2121
}
2222

2323
abstract class ZZ extends Predicate {}
24+
25+
abstract class Config {
26+
String get datasetId; //OK -- Issue #64
27+
}

0 commit comments

Comments
 (0)