Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Commit 1cb730f

Browse files
committed
Adjust lint reporting to use Token
1 parent 3f3a3cc commit 1cb730f

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

lib/src/rules/avoid_unstable_final_fields.dart

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ abstract class _AbstractVisitor extends ThrowingAstVisitor<void> {
183183
return false;
184184
}
185185

186-
void doReportLint(ClassMember node, AstNode name) {
186+
List<DiagnosticMessage> _computeContextMessages() {
187187
var contextMessages = <DiagnosticMessage>[];
188188
for (var cause in causes) {
189189
var length = cause.nameLength;
@@ -193,14 +193,18 @@ abstract class _AbstractVisitor extends ThrowingAstVisitor<void> {
193193
contextMessages.add(
194194
DiagnosticMessageImpl(
195195
filePath: cause.library.source.fullName,
196-
message: "The declaration of '$name' that requires this "
196+
message: 'The declaration that requires this '
197197
'declaration to be stable is',
198198
offset: offset,
199199
length: length,
200200
url: null),
201201
);
202202
}
203-
rule.reportLint(name, contextMessages: contextMessages);
203+
return contextMessages;
204+
}
205+
206+
void doReportLint(Token? name) {
207+
rule.reportLintForToken(name, contextMessages: _computeContextMessages());
204208
}
205209

206210
// The following visitor methods will only be executed in the situation
@@ -638,7 +642,7 @@ class _FieldVisitor extends _AbstractVisitor {
638642
libraryUri ??= declaredElement.library.source.uri;
639643
name ??= Name(libraryUri, declaredElement.name);
640644
if (_inheritsStability(interfaceElement, name)) {
641-
doReportLint(node, variable.name);
645+
doReportLint(variable.name2);
642646
}
643647
}
644648
}
@@ -660,7 +664,7 @@ class _MethodVisitor extends _AbstractVisitor {
660664
var name = Name(libraryUri, declaredElement.name);
661665
if (!_inheritsStability(enclosingElement, name)) return;
662666
node.body.accept(this);
663-
if (!isStable) doReportLint(node, node.name);
667+
if (!isStable) doReportLint(node.name2);
664668
} else {
665669
// Extensions cannot override anything.
666670
}

0 commit comments

Comments
 (0)