Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Module names and class names can conflict in generated JS #69

Closed
vsmenon opened this issue Feb 27, 2015 · 2 comments
Closed

Module names and class names can conflict in generated JS #69

vsmenon opened this issue Feb 27, 2015 · 2 comments

Comments

@vsmenon
Copy link
Contributor

vsmenon commented Feb 27, 2015

This comes up in DeltaBlue and other benchmarks:

var BenchmarkBase;
(function(BenchmarkBase) {
  ...
  class BenchmarkBase extends dart.Object { ... }
  ...

Running this triggers:

lib/src/DeltaBlue/dart/ddc/BenchmarkBase/BenchmarkBase.js:65: SyntaxError: Identifier 'BenchmarkBase' has already been declared

when the class is parsed by v8.

@jmesserly
Copy link
Contributor

yeah hoping we can fix this and some related issues via #34: use ES6 modules and have a more sane desugaring

@jmesserly
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants