Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Support loading files via non-file: URIs #609

Closed
nex3 opened this issue Jul 27, 2016 · 5 comments
Closed

Support loading files via non-file: URIs #609

nex3 opened this issue Jul 27, 2016 · 5 comments

Comments

@nex3
Copy link

nex3 commented Jul 27, 2016

Currently the dev compiler only supports compiling sources with file: URIs. To match other implementations, it should support http:, https: and data: URIs as well.

This is blocking dart-lang/test#414, which needs to be able to compile from HTTP to support pub serve.

@jmesserly
Copy link
Contributor

(marked P1 if it's a blocker)

I can see how data could work, but what is http(s) supposed to do for a command line compiler? I don't see any code in analyzer_cli for it, and none of those URI schemes seem to work for dartanalyzer (as far as I can tell). If there's some way to make this work in Analyzer I'm all for it. (And probably we should implement it in pkg:analyzer so DDC doesn't need custom logic, and all front ends can get the same URI support...)

@jmesserly
Copy link
Contributor

Aside, the idea of a compiler needing to support HTTP is a bit crazy on principle :). But I can see how we got there with our crazy concurrency story :|

@jmesserly
Copy link
Contributor

Hey @nex3 did you have thoughts on how we could support this? It didn't look like Analyzer has support for these URI schemes but I may have missed something.

@nex3
Copy link
Author

nex3 commented Aug 11, 2016

I don't really know the internals of analyzer that well... you may have to add support for other URI schemes in its code. Doesn't it have a fairly separate abstraction for reading inputs that you can hook into?

@vsmenon
Copy link
Contributor

vsmenon commented Sep 6, 2016

This issue was moved to dart-lang/sdk#27266

@vsmenon vsmenon closed this as completed Sep 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants