Initial support for f-bound quantification patterns

This doesn't fix all issues (see remaining broken test), but it unblocks angular.

[email protected]

Review URL: https://codereview.chromium.org/1431403002 .

Author: vsmenon

lib/src/codegen/js_codegen.dart

@@ -566,14 +566,39 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ClosureAnnotator {
         [genericName, typeParams, body, name]);
   }
 
+  final _hasDeferredSupertype = new HashSet<ClassElement>();
+
+  bool _deferIfNeeded(DartType type, ClassElement current) {
+    if (type is ParameterizedType) {
+      var typeArguments = type.typeArguments;
+      for (var typeArg in typeArguments) {
+        var typeElement = typeArg.element;
+        // FIXME(vsm): This does not track mutual recursive dependences.
+        if (current == typeElement || _deferIfNeeded(typeArg, current)) {
+          return true;
+        }
+      }
+    }
+    return false;
+  }
+
   JS.Expression _classHeritage(ClassElement element) {
     var type = element.type;
     if (type.isObject) return null;
 
     // Assume we can load eagerly, until proven otherwise.
     _loader.startTopLevel(element);
 
-    JS.Expression heritage = _emitTypeName(type.superclass);
+    // Find the super type
+    JS.Expression heritage;
+    var supertype = type.superclass;
+    if (_deferIfNeeded(supertype, element)) {
+      // Fall back to raw type.
+      supertype = fillDynamicTypeArgs(supertype.element.type, rules.provider);
+      _hasDeferredSupertype.add(element);
+    }
+    heritage = _emitTypeName(supertype);
+
     if (type.mixins.isNotEmpty) {
       var mixins = type.mixins.map(_emitTypeName).toList();
       mixins.insert(0, heritage);
@@ -701,6 +726,12 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ClosureAnnotator {
           [classElem.name, _propertyName(jsPeerName)]));
     }
 
+    // Deferred Superclass
+    if (_hasDeferredSupertype.contains(classElem)) {
+      body.add(js.statement('#.prototype.__proto__ = #.prototype;',
+          [name, _emitTypeName(classElem.type.superclass)]));
+    }
+
     // Interfaces
     if (classElem.interfaces.isNotEmpty) {
       body.add(js.statement('#[dart.implements] = () => #;', [

test/browser/language_tests.js

@@ -103,8 +103,6 @@
     'external_test_10_multi',
     'external_test_13_multi',
     'external_test_20_multi',
-    'f_bounded_equality_test',
-    'f_bounded_quantification2_test',
     'f_bounded_quantification3_test',
     'factory_type_parameter_test',
     'fast_method_extraction_test',