Allow null args to dynamic invocations

Fixes #194.

BUG=
[email protected]

Review URL: https://codereview.chromium.org/1149243002

Author: leafpetersen

lib/runtime/dart_runtime.js

@@ -240,6 +240,10 @@ var dart, _js_helper, _js_primitives;
   }
   dart.is = instanceOf;
 
+  function instanceOfOrNull(obj, type) {
+    return (obj == null) || instanceOf(obj, type);
+  }
+
   /**
    * Computes the canonical type.
    * This maps JS types onto their corresponding Dart Type.
@@ -465,17 +469,15 @@ var dart, _js_helper, _js_primitives;
       if (actuals.length < this.args.length) return false;
       var index = 0;
       for(let i = 0; i < this.args.length; ++i) {
-        let t = realRuntimeType(actuals[i]);
-        if (!isSubtype(t, this.args[i])) return false;
+        if (!instanceOfOrNull(actuals[i], this.args[i])) return false;
         ++index;
       }
       if (actuals.length == this.args.length) return true;
       let extras = actuals.length - this.args.length;
       if (this.optionals.length > 0) {
         if (extras > this.optionals.length) return false;
-        for(let i = 0; i < extras; ++i) {
-          let t = realRuntimeType(actuals[index + i]);
-          if (!isSubtype(t, this.optionals[i])) return false;
+        for(let i = 0, j=index; i < extras; ++i, ++j) {
+          if (!instanceOfOrNull(actuals[j], this.optionals[i])) return false;
         }
         return true;
       }
@@ -493,8 +495,7 @@ var dart, _js_helper, _js_primitives;
         if (!(Object.prototype.hasOwnProperty.call(this.named, name))) {
           return false;
         }
-        let t = realRuntimeType(opts[name]);
-        if (!isSubtype(t, this.named[name])) return false;
+        if (!instanceOfOrNull(opts[name], this.named[name])) return false;
       }
       return true;
     }

test/browser/runtime_tests.js

@@ -479,27 +479,32 @@ suite('instanceOf', () => {
 
     // Method send
     assert.equal(dart.dsend(o, 'm', 3, 4), 3);
+    assert.equal(dart.dsend(o, 'm', null, 4), null);
     assert.throws(() => dart.dsend(o, 'm', 3));
     assert.throws(() => dart.dsend(o, 'm', "hello", "world"));
     assert.throws(() => dart.dsend(o, 'q', 3));
 
     // Method send through a field
     assert.equal(dart.dsend(o, 'f', 3), 3);
+    assert.equal(dart.dsend(o, 'f', null), null);
     assert.throws(() => dart.dsend(o, 'f', "hello"));
     assert.throws(() => dart.dsend(o, 'f', 3, 4));
 
     // Static method call
     assert.equal(dart.dcall(Tester.s, "hello"), "hello");
+    assert.equal(dart.dcall(Tester.s, null), null);
     assert.throws(() => dart.dcall(Tester.s, "hello", "world"));
     assert.throws(() => dart.dcall(Tester.s, 0, 1));
 
     // Calling an object with a call method
     assert.equal(dart.dcall(o, 3), 3);
+    assert.equal(dart.dcall(o, null), null);
     assert.throws(() => dart.dcall(o, "hello"));
     assert.throws(() => dart.dcall(o, 3, 4));
 
     // Calling through a field containing an object with a call method
     assert.equal(dart.dsend(o, 'me', 3), 3);
+    assert.equal(dart.dsend(o, 'me', null), null);
     assert.throws(() => dart.dsend(o, 'me', "hello"));
     assert.throws(() => dart.dsend(o, 'me', 3, 4));
   });