Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit 53a7155

Browse files
committed
Check for SDK error regressions on presubmit
This is to keep us from inadvertently regressing the SDK. See related bug #103 [email protected] Review URL: https://codereview.chromium.org/1154213008
1 parent 02e41a4 commit 53a7155

File tree

2 files changed

+1213
-2
lines changed

2 files changed

+1213
-2
lines changed

tool/build_sdk.sh

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,16 @@ if [[ -d lib/runtime/dart ]] ; then
1313
fi
1414

1515
# TODO(jmesserly): for now we're suppressing errors in SDK compilation
16-
dart -c bin/devc.dart --no-source-maps --sdk-check --force-compile -l shout \
17-
--dart-sdk test/generated_sdk -o lib/runtime/ dart:core || true
16+
dart -c bin/devc.dart --no-source-maps --sdk-check --force-compile -l warning \
17+
--dart-sdk test/generated_sdk -o lib/runtime/ dart:core \
18+
> test/generated_sdk/sdk_errors.txt || true
19+
20+
if ! diff tool/sdk_expected_errors.txt test/generated_sdk/sdk_errors.txt ; then
21+
echo
22+
echo 'SDK errors have changed. To update expectations, run:'
23+
echo '$ cp test/generated_sdk/sdk_errors.txt tool/sdk_expected_errors.txt'
24+
exit 1
25+
fi
1826

1927
if [[ ! -f lib/runtime/dart/core.js ]] ; then
2028
echo 'core.js not found, assuming build failed.'

0 commit comments

Comments
 (0)