remove another old analyzer workaround

[email protected]

Review URL: https://codereview.chromium.org/1089693002

Author: John Messerly

lib/runtime/dart/async.js

@@ -920,7 +920,7 @@ var async;
       onData(handleData) {
         if (handleData == null)
           handleData = dart.as(_nullDataHandler, dart.functionType(dart.void, [T]));
-        this[_onData] = dart.as(this[_zone].registerUnaryCallback(handleData), _DataHandler);
+        this[_onData] = dart.as(this[_zone].registerUnaryCallback(handleData), _DataHandler$(T));
       }
       onError(handleError) {
         if (handleError == null)
@@ -4303,7 +4303,7 @@ var async;
           if (handleDone == null)
             handleDone = _StreamHandlerTransformer[_defaultHandleDone];
           return new (_HandlerEventSink$(S, T))(handleData, handleError, handleDone, outputSink);
-        }, _SinkMapper));
+        }, _SinkMapper$(S, T)));
       }
       bind(stream) {
         return super.bind(stream);

lib/runtime/dart/collection.js

@@ -2828,7 +2828,7 @@ var collection;
           compare = null;
         if (isValidKey === void 0)
           isValidKey = null;
-        this[_comparator] = dart.as(compare == null ? core.Comparable.compare : compare, core.Comparator);
+        this[_comparator] = dart.as(compare == null ? core.Comparable.compare : compare, core.Comparator$(K));
         this[_validKey] = dart.as(isValidKey != null ? isValidKey : v => dart.is(v, K), _Predicate);
         super._SplayTree();
       }

lib/runtime/dart/core.js

@@ -1141,7 +1141,7 @@ var core;
       _GeneratorIterable(end, generator) {
         this[_end] = end;
         this[_start] = 0;
-        this[_generator] = dart.as(generator != null ? generator : _GeneratorIterable[_id], _Generator);
+        this[_generator] = dart.as(generator != null ? generator : _GeneratorIterable[_id], _Generator$(E));
         super.IterableBase();
       }
       slice(start, end, generator) {

lib/src/codegen/js_codegen.dart

@@ -1102,14 +1102,10 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
 
     var typeArgs = null;
     if (type is ParameterizedType) {
-      // TODO(jmesserly): this is a workaround for an analyzer bug, see:
-      // https://github.com/dart-lang/dev_compiler/commit/a212d59ad046085a626dd8d16881cdb8e8b9c3fa
-      if (type is! FunctionType || element is FunctionTypeAlias) {
-        var args = type.typeArguments;
-        if (args.any((a) => a != types.dynamicType)) {
-          name = '$name\$';
-          typeArgs = args.map(_emitTypeName);
-        }
+      var args = type.typeArguments;
+      if (args.any((a) => a != types.dynamicType)) {
+        name = '$name\$';
+        typeArgs = args.map(_emitTypeName);
       }
     }
 
@@ -1277,7 +1273,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
     var named = <JS.Property>[];
     for (var arg in node.arguments) {
       if (arg is NamedExpression) {
-        named.add(visitNamedExpression(arg));
+        named.add(_visit(arg));
       } else {
         args.add(_visit(arg));
       }