Refactor SARIFAnalysisReport::addFinding() from 2 to 1 line!

mario-campos · mario-campos · commit 0f96b45deba8 · 2022-12-20T16:12:38.000-06:00
Much thanks to @danmar for the tip :)
diff --git a/cli/sarifanalysisreport.cpp b/cli/sarifanalysisreport.cpp
@@ -24,8 +24,7 @@ SARIFAnalysisReport::SARIFAnalysisReport( std::string versionNumber)
     : mVersionNumber(std::move(versionNumber)) {}
 
 void SARIFAnalysisReport::addFinding(const ErrorMessage &msg) {
-    std::map<std::string, std::vector<ErrorMessage>>::iterator it = mFindings.insert(mFindings.begin(), {msg.id, std::vector<ErrorMessage>()});
-    it->second.push_back(msg);
+    mFindings[msg.id].push_back(msg);
 }
 
 static std::map<std::string, picojson::value> text(const std::string& s) {

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,7 @@ SARIFAnalysisReport::SARIFAnalysisReport( std::string versionNumber)`
`24`	`24`	`: mVersionNumber(std::move(versionNumber)) {}`
`25`	`25`
`26`	`26`	`void SARIFAnalysisReport::addFinding(const ErrorMessage &msg) {`
`27`		`- std::map<std::string, std::vector<ErrorMessage>>::iterator it = mFindings.insert(mFindings.begin(), {msg.id, std::vector<ErrorMessage>()});`
`28`		`- it->second.push_back(msg);`
	`27`	`+ mFindings[msg.id].push_back(msg);`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`static std::map<std::string, picojson::value> text(const std::string& s) {`