Suppress superflous errors generated closing a forwarding connection #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection After manually closing a forward connection, several threads only exit after a call to accept() fails due to the the underlying resource being cleanly closed. This is not an error, and these errors can distract from a clean shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that I've had this change locally on disk for a year. If you look at the logic for
ConnListener.Close(), it callscl.listener.Close(), which in turn causeslistener.Accept()calls in related goroutines to return with errors. These errors are logged to stderr before the routines end.These errors should not be emitted when the connection is manually/cleanly closed. The existing call to
close(cl.quit)has no impact on preventing these errors.Especially when using
go-iosas a library where connections are dynamically opened and closed, these errors are quite undesirable.