Skip to content

🐛 BUG: Fix missing bottom margin in footer links when no comments are present #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
junaiddshaukat opened this issue Mar 26, 2025 · 4 comments
Open
1 task done

Comments

@junaiddshaukat
Copy link

What went wrong? 🤔

I notice that in the webapp there is a footer layout issue when the post have no comments

Expected Behavior

  • The footer should have consistent spacing whether comments are present or not.

Steps to Reproduce Issue

1. Open a post **without any comments**.  
2. Scroll down to the footer section.  
3. Notice that the links do not have proper bottom spacing.

Solution Proposed

Proposed Fix

  • Ensure that the footer has a consistent bottom margin regardless of the presence of comments.

Screenshots

Image

Environment

No response

Browsers

No response

OS

No response

Version of daily.dev

No response

Additional Context

- If the post has **comments**, this issue **does not occur** because the comment section naturally adds spacing.

Code of Conduct

  • I follow the conditions of this project.
@sabdailydev
Copy link

sabdailydev commented Mar 26, 2025

Thanks for reporting this issue. We have accepted it and it will be fixed in the future. It is open for public contribution

@junaiddshaukat
Copy link
Author

@sabdailydev I have created a PR in which I have fixed this issues.
Here is the PR Link: dailydotdev/apps#4310

@junaiddshaukat
Copy link
Author

Thanks for reporting this issue. We have accepted it and it will be fixed in the future. It is open for public contribution

Can you review my PR for this issue: dailydotdev/apps#4310

@sabdailydev
Copy link

@junaiddshaukat Thanks, the PR review is in the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants