Skip to content

feat: serve the built site with lwsjs #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2020
Merged

feat: serve the built site with lwsjs #69

merged 4 commits into from
Jul 23, 2020

Conversation

martinliptak
Copy link
Contributor

@martinliptak martinliptak commented Jul 22, 2020 •
edited
Loading

Solves #59, #57 and #51.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@martinliptak martinliptak marked this pull request as draft July 22, 2020 10:33
@martinliptak martinliptak changed the base branch from beta to master July 22, 2020 10:34
@martinliptak martinliptak changed the base branch from master to beta July 22, 2020 10:36
@martinliptak martinliptak changed the base branch from beta to add-ci-tests July 22, 2020 10:36
@martinliptak martinliptak changed the base branch from add-ci-tests to master July 22, 2020 10:37
@martinliptak martinliptak reopened this Jul 22, 2020
@martinliptak martinliptak changed the title Switch to LWSJS serve site with lwsjs Jul 22, 2020
martinliptak
martinliptak commented Jul 22, 2020
View reviewed changes
src/index.js
directory,
port,
spa
}).server
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other lws params that could be useful for somebody?
https://github.com/lwsjs/local-web-server

@martinliptak martinliptak marked this pull request as ready for review July 22, 2020 11:21
@martinliptak
Copy link
Contributor Author

martinliptak commented Jul 22, 2020 •
edited
Loading

Just noticed #66. Using process.env.DEPLOY_URL is actually a better solution because it also verifies Netlify redirects setup.

@martinliptak martinliptak changed the title serve site with lwsjs fix: serve site with lwsjs Jul 22, 2020
bahmutov
bahmutov reviewed Jul 23, 2020
View reviewed changes
README.md
# local Cypress plugin will test our site after it is built
package = "netlify-plugin-cypress"
[plugins.inputs]
spa = "index.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so good

@bahmutov
Copy link
Contributor

Nice! I will mark this as a feature, since spa parameter is really a feature in my opinion. Appreciate such good PR

@bahmutov bahmutov changed the title fix: serve site with lwsjs feat: serve the built site with lwsjs Jul 23, 2020
@bahmutov bahmutov merged commit c28c585 into cypress-io:master Jul 23, 2020
@bahmutov
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinliptak @CLAassistant @bahmutov