Skip to content

fix: Fail build if Cypress runs into a problem #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020

Conversation

erquhart
Copy link
Contributor

Currently the Cypress plugin allows the build to continue if Cypress itself fails to run. This PR fails the build in this case.

@CLAassistant
Copy link

CLAassistant commented May 28, 2020

CLA assistant check
All committers have signed the CLA.

@bahmutov bahmutov self-requested a review May 28, 2020 19:14
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @erquhart this looks good

@bahmutov bahmutov changed the title Fail build if Cypress runs into a problem fix: Fail build if Cypress runs into a problem May 28, 2020
@bahmutov bahmutov merged commit a96f86c into cypress-io:master May 28, 2020
@bahmutov
Copy link
Contributor

🎉 This PR is included in version 1.3.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@erquhart erquhart deleted the patch-1 branch June 11, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants