Skip to content

fix: Add engines.node field #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020
Merged

fix: Add engines.node field #53

merged 1 commit into from
May 28, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 27, 2020

An engines.node field in package.json can be added in Build plugins.
When present, a nice error message will be shown to users with old Node.js versions.

A Node 8 user encountered this problem with netlify-plugin-cypress. This plugin requires Node 10 due to the got dependency.

@bahmutov bahmutov changed the title Add engines.node field fix: Add engines.node field May 28, 2020
@bahmutov bahmutov merged commit 2a668b9 into cypress-io:master May 28, 2020
@bahmutov
Copy link
Contributor

Thank you @ehmicky

@bahmutov
Copy link
Contributor

🎉 This PR is included in version 1.3.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ehmicky ehmicky deleted the chore/add-engines-node branch May 28, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants