Skip to content

Conversation

@MikeMcC399
Copy link
Collaborator

Issue

The README files deal inconsistently with information about which tags are used by Cypress Docker images:

Background

Tags are created through factory/docker-compose.yml.

- ${REPO_PREFIX-}cypress/factory:latest
- ${REPO_PREFIX-}cypress/factory:${FACTORY_VERSION}

- ${REPO_PREFIX-}cypress/base:latest
- ${REPO_PREFIX-}cypress/base:${BASE_IMAGE_TAG}

- ${REPO_PREFIX-}cypress/browsers:latest
- ${REPO_PREFIX-}cypress/browsers:${BROWSERS_IMAGE_TAG}

- ${REPO_PREFIX-}cypress/included:latest
- ${REPO_PREFIX-}cypress/included:${INCLUDED_IMAGE_SHORT_TAG}
- ${REPO_PREFIX-}cypress/included:${INCLUDED_IMAGE_TAG}

in combination with

# Tags used for the docker images generated from the factory. Keep in mind the docker images will only release if these versions change.
BASE_IMAGE_TAG="${NODE_VERSION}"
BROWSERS_IMAGE_TAG="node-${NODE_VERSION}-chrome-${CHROME_VERSION}-ff-${FIREFOX_VERSION}-edge-${EDGE_VERSION}"
INCLUDED_IMAGE_SHORT_TAG="${CYPRESS_VERSION}"
INCLUDED_IMAGE_TAG="cypress-${CYPRESS_VERSION}-${BROWSERS_IMAGE_TAG}"

Changes

  • The example versions used in the README are refreshed.

  • The information described in the Background section above is extracted and added to the respective README files.

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 force-pushed the add-tag-infos branch 2 times, most recently from 4db91e1 to bd66f0b Compare June 10, 2024 07:55
@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 10, 2024 08:17
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks!

@jennifer-shehane jennifer-shehane merged commit b0e0450 into cypress-io:master Jun 10, 2024
@MikeMcC399 MikeMcC399 deleted the add-tag-infos branch June 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants