Skip to content

Conversation

@antonkomarev
Copy link
Member

@antonkomarev antonkomarev commented Jan 4, 2017

Still thinking about naming of method which will remove closed flag: unclose() or open().

If open() will be chosen in future there will be Classic\Open flag which will have methods open() and close() to follow naming convention. These flags wouldn't been able to work together because methods open() and close() will be broken.

WIth unclose() such collisions are excluded but Classic\Active flag already have activate() & deactivate() methods.

@antonkomarev antonkomarev mentioned this pull request Jan 4, 2017
14 tasks
@antonkomarev antonkomarev added this to the v3.0 milestone Jan 5, 2017
@antonkomarev antonkomarev merged commit c93ccdd into master Jan 6, 2017
@antonkomarev antonkomarev deleted the feature/is-closed branch January 6, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants