mostly documentation updates #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
added a commit
that referenced
this pull request
Dec 22, 2023
* prototype (#1) * first iteration * dynamic period * docstring * feedback * linting * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * midpoint docstring * flak8 formatting * PR 1875 (#2) * kandersolar feedback (#3) * addressing feedback from Kandersolar * Review (#4) added hack for ISO periods in Pandas 0.25 and clearsky parameter maps * comment on pandas version * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Adams's feedback * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Adams's feedback * Last minor changes * added test for _get_solcast * feat: add additional test coverage (#5) Co-authored-by: Hugh Cutcher <[email protected]> * linting --------- Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Adam R. Jensen <[email protected]> Co-authored-by: hugh-solcast <[email protected]> Co-authored-by: Hugh Cutcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...plus
infer_temp_model --> infer_temperature_model.All I really wanted to do was add the
Examplessection to the new docstrings but all of these changes are necessary to get the documentation to build mostly without problems. There are still some other unrelated doc issues that I will address later.Struggled with cleaning up the whats new in combination with merging your recent changes, so read that carefully.
Assuming
temperature_model_parametersfor now, but happy to change that later if needed.