Skip to content

Commit fb59a52

Browse files
pkitszelanguy11
authored andcommitted
ice: ice_probe: init ice_adapter after HW init
Move ice_adapter initialization to be after HW init, so it could use HW capabilities, like number of PFs. This is needed for devlink-resource based RSS LUT size management for PF/VF (not in this series). Reviewed-by: Marcin Szycik <[email protected]> Signed-off-by: Przemek Kitszel <[email protected]> Reviewed-by: Kalesh AP <[email protected]> Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <[email protected]>
1 parent 5d5d9c2 commit fb59a52

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

drivers/net/ethernet/intel/ice/ice_main.c

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5277,13 +5277,7 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent)
52775277
}
52785278

52795279
pci_set_master(pdev);
5280-
5281-
adapter = ice_adapter_get(pdev);
5282-
if (IS_ERR(adapter))
5283-
return PTR_ERR(adapter);
5284-
52855280
pf->pdev = pdev;
5286-
pf->adapter = adapter;
52875281
pci_set_drvdata(pdev, pf);
52885282
set_bit(ICE_DOWN, pf->state);
52895283
/* Disable service task until DOWN bit is cleared */
@@ -5314,12 +5308,19 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent)
53145308
err = ice_init_hw(hw);
53155309
if (err) {
53165310
dev_err(dev, "ice_init_hw failed: %d\n", err);
5317-
goto unroll_adapter;
5311+
return err;
53185312
}
53195313

5314+
adapter = ice_adapter_get(pdev);
5315+
if (IS_ERR(adapter)) {
5316+
err = PTR_ERR(adapter);
5317+
goto unroll_hw_init;
5318+
}
5319+
pf->adapter = adapter;
5320+
53205321
err = ice_init(pf);
53215322
if (err)
5322-
goto unroll_hw_init;
5323+
goto unroll_adapter;
53235324

53245325
devl_lock(priv_to_devlink(pf));
53255326
err = ice_load(pf);
@@ -5338,10 +5339,10 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent)
53385339
unroll_init:
53395340
devl_unlock(priv_to_devlink(pf));
53405341
ice_deinit(pf);
5341-
unroll_hw_init:
5342-
ice_deinit_hw(hw);
53435342
unroll_adapter:
53445343
ice_adapter_put(pdev);
5344+
unroll_hw_init:
5345+
ice_deinit_hw(hw);
53455346
return err;
53465347
}
53475348

0 commit comments

Comments
 (0)