Skip to content

Commit f64768b

Browse files
arndbjmberg-intel
authored andcommitted
wifi: rt2x00: fix CRC_CCITT dependency
Compile-testing this driver on Arm platforms shows a link failure when the CRC functions are not part of the kernel: x86_64-linux-ld: drivers/net/wireless/ralink/rt2x00/rt2800lib.o: in function `rt2800_check_firmware': rt2800lib.c:(.text+0x20e5): undefined reference to `crc_ccitt' Move the select statement to the correct Kconfig symbol to match the call site. Fixes: 311b05e ("wifi: rt2x00: add COMPILE_TEST") Signed-off-by: Arnd Bergmann <[email protected]> Acked-by: Stanislaw Gruszka <[email protected]> Reviewed-by: Sergio Paracuellos <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Johannes Berg <[email protected]>
1 parent 2d52c9e commit f64768b

File tree

1 file changed

+1
-2
lines changed
  • drivers/net/wireless/ralink/rt2x00

1 file changed

+1
-2
lines changed

drivers/net/wireless/ralink/rt2x00/Kconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ config RT2800PCI
6666
select RT2X00_LIB_PCI
6767
select RT2X00_LIB_FIRMWARE
6868
select RT2X00_LIB_CRYPTO
69-
select CRC_CCITT
7069
select EEPROM_93CX6
7170
help
7271
This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
@@ -142,7 +141,6 @@ config RT2800USB
142141
select RT2X00_LIB_USB
143142
select RT2X00_LIB_FIRMWARE
144143
select RT2X00_LIB_CRYPTO
145-
select CRC_CCITT
146144
help
147145
This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
148146
Supported chips: RT2770, RT2870 & RT3070, RT3071 & RT3072
@@ -217,6 +215,7 @@ config RT2800SOC
217215

218216
config RT2800_LIB
219217
tristate
218+
select CRC_CCITT
220219

221220
config RT2800_LIB_MMIO
222221
tristate

0 commit comments

Comments
 (0)