Skip to content

Commit 2c2192e

Browse files
BitsByWillkuba-moo
authored andcommitted
net/sched: Remove unnecessary WARNING condition for empty child qdisc in htb_activate
The WARN_ON trigger based on !cl->leaf.q->q.qlen is unnecessary in htb_activate. htb_dequeue_tree already accounts for that scenario. Fixes: 1da177e ("Linux-2.6.12-rc2") Signed-off-by: William Liu <[email protected]> Reviewed-by: Savino Dicanosa <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 15de71d commit 2c2192e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/sched/sch_htb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ htb_change_class_mode(struct htb_sched *q, struct htb_class *cl, s64 *diff)
592592
*/
593593
static inline void htb_activate(struct htb_sched *q, struct htb_class *cl)
594594
{
595-
WARN_ON(cl->level || !cl->leaf.q || !cl->leaf.q->q.qlen);
595+
WARN_ON(cl->level || !cl->leaf.q);
596596

597597
if (!cl->prio_activity) {
598598
cl->prio_activity = 1 << cl->prio;

0 commit comments

Comments
 (0)