clippy fixes

Signed-off-by: Dave Huseby <[email protected]>

Author: dhuseby

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "multicid"
-version = "1.0.4"
+version = "1.0.5"
 edition = "2021"
 authors = ["Dave Grantham <[email protected]>"]
 description = "Multicodec compatible content identifier implementation"

src/cid.rs

@@ -66,18 +66,18 @@ impl EncodingInfo for Cid {
     }
 }
 
-impl Into<Vec<u8>> for Cid {
-    fn into(self) -> Vec<u8> {
+impl From<Cid> for Vec<u8> {
+    fn from(cid: Cid) -> Self {
         let mut v = Vec::default();
         // if we're not a v0 Cid, add in the version and the encoding codec
-        if self.codec() != Codec::Identity {
+        if cid.codec() != Codec::Identity {
             // add in the Cid codec
-            v.append(&mut self.codec.clone().into());
+            v.append(&mut cid.codec.into());
             // add in the target encoding codec
-            v.append(&mut self.target_codec.clone().into());
+            v.append(&mut cid.target_codec.into());
         }
         // add in the multihash data
-        v.append(&mut self.hash.clone().into());
+        v.append(&mut cid.hash.into());
         v
     }
 }
@@ -211,14 +211,14 @@ impl Builder {
         }
         Ok(EncodedCid::new(
             self.base_encoding
-                .unwrap_or_else(|| Cid::preferred_encoding()),
+                .unwrap_or_else(Cid::preferred_encoding),
             self.try_build()?,
         ))
     }
 
     /// build the cid
     pub fn try_build(&self) -> Result<Cid, Error> {
-        if let Some(codec) = self.codec.clone() {
+        if let Some(codec) = self.codec {
             // build a v1 or later Cid
             Ok(Cid {
                 codec,

src/lib.rs

@@ -1,6 +1,6 @@
 // SPDX-License-Idnetifier: Apache-2.0
 
-//!
+//! multicid
 #![warn(missing_docs)]
 #![deny(
     trivial_casts,

src/serde/de.rs

@@ -17,7 +17,7 @@ impl<'de> Deserialize<'de> for Cid {
     where
         D: Deserializer<'de>,
     {
-        const FIELDS: &'static [&'static str] = &["version", "encoding", "hash"];
+        const FIELDS: &[&str] = &["version", "encoding", "hash"];
 
         #[derive(Deserialize)]
         #[serde(field_identifier, rename_all = "lowercase")]
@@ -131,7 +131,7 @@ impl<'de> Deserialize<'de> for Vlad {
     where
         D: Deserializer<'de>,
     {
-        const FIELDS: &'static [&'static str] = &["nonce", "cid"];
+        const FIELDS: &[&str] = &["nonce", "cid"];
 
         #[derive(Deserialize)]
         #[serde(field_identifier, rename_all = "lowercase")]

src/vlad.rs

@@ -72,15 +72,15 @@ impl EncodingInfo for Vlad {
     }
 }
 
-impl Into<Vec<u8>> for Vlad {
-    fn into(self) -> Vec<u8> {
+impl From<Vlad> for Vec<u8> {
+    fn from(vlad: Vlad) -> Vec<u8> {
         let mut v = Vec::default();
         // add the sigil
         v.append(&mut SIGIL.into());
         // add the nonce
-        v.append(&mut self.nonce.clone().into());
+        v.append(&mut vlad.nonce.into());
         // add the cid
-        v.append(&mut self.cid.clone().into());
+        v.append(&mut vlad.cid.into());
         v
     }
 }
@@ -168,7 +168,7 @@ impl Builder {
     pub fn try_build_encoded(&self) -> Result<EncodedVlad, Error> {
         Ok(EncodedVlad::new(
             self.base_encoding
-                .unwrap_or_else(|| Vlad::preferred_encoding()),
+                .unwrap_or_else(Vlad::preferred_encoding),
             self.try_build()?,
         ))
     }