Skip to content

Process Substitution Fails #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adam-grant-hendry opened this issue Oct 24, 2022 · 1 comment · Fixed by #7
Closed

Process Substitution Fails #4

adam-grant-hendry opened this issue Oct 24, 2022 · 1 comment · Fixed by #7

Comments

@adam-grant-hendry
Copy link

The process substitution

--passphrase-file <(echo ***)

in action.yml

https://github.com/cresh-io/action-gpg/blob/69c283c829f9f89f282f110f705db67a2b263777/action.yml#L53-L55

fails in instances where GitHub Actions falls back to using sh (sh does not support process substitutions unless POSIX mode is turned off with set +o posix).

Per the GitHub Docs for jobs.<job_id>.steps[*].shell, shell: bash behaves as follows:

The default shell on non-Windows platforms with a fallback to sh. When specifying a bash shell on Windows, the bash shell included with Git for Windows is used.

Please add set +o posix to step Import GPG Key.
@adam-grant-hendry adam-grant-hendry mentioned this issue Oct 25, 2022
Closed
sylver added a commit that referenced this issue Jul 12, 2023
@sylver
fix: support process substitutions in sh
118404c 
Fix #4
sylver added a commit that referenced this issue Jul 13, 2023
@sylver
fix: support process substitutions in sh
f75c5d9 
Fix #4
sylver added a commit that referenced this issue Jul 13, 2023
@sylver
feat!: use default sh shell instead of bash
afa08c2 
* improve compatibility across environment
* avoid process substitutions and `bash` specifics when GitHub Actions
  falls back to using `sh` anyway

Fixes #4
sylver added a commit that referenced this issue Jul 13, 2023
@sylver
feat!: use default sh shell instead of bash
9203d1c 
* improve compatibility across environment
* avoid process substitutions and `bash` specifics when GitHub Actions
  falls back to using `sh` anyway

Fixes #4
@sylver sylver mentioned this issue Jul 13, 2023
Merged
@sylver sylver closed this as completed in #7 Jul 13, 2023
sylver added a commit that referenced this issue Jul 13, 2023
@sylver
feat!: use default sh shell instead of bash
d129a7a 
* improve compatibility across environment
* avoid process substitutions and `bash` specifics when GitHub Actions
  falls back to using `sh` anyway

Fixes #4
@sylver
Copy link
Member

sylver commented Jul 13, 2023

Hi @adam-grant-hendry

Sorry for the delay, but we took your issue into account and pushed a few improvements in a new v2 tag.

sylver added a commit that referenced this issue Jul 17, 2023
@sylver
feat!: use default sh shell instead of bash
1de9291 
* improve compatibility across environment
* avoid process substitutions and `bash` specifics when GitHub Actions
  falls back to using `sh` anyway

Fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multiple improvements creshpay/action-gpg
2 participants
@sylver @adam-grant-hendry