Skip to content

Commit 9984cc4

Browse files
committed
fixup! Adjust connect arguments to enable SSL using SQLAlchemy DB URI
1 parent 1b1136a commit 9984cc4

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

CHANGES.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Unreleased
1313

1414
- Adjusted connect arguments to accept credentials within the HTTP URI.
1515

16-
- Adjusted connect arguments to enable SSL using SQLAlchemy DB URI.
16+
- Optionally enable SSL using SQLAlchemy DB URI with parameter ``?ssl=true``.
1717

1818
2020/09/28 0.26.0
1919
=================

src/crate/client/sqlalchemy/dialect.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,6 @@ def connect(self, host=None, port=None, *args, **kwargs):
197197
server = kwargs.pop('servers')
198198
servers = to_list(server)
199199
if servers:
200-
# Evaluate "ssl" connection URI query parameter.
201-
# TODO: Evaluate more parameters like `ssl_ca`, `ssl_key`, `ssl_cert`,
202-
# `ssl_capath` and `ssl_cipher`.
203200
if "ssl" in kwargs:
204201
use_ssl = asbool(kwargs.pop("ssl"))
205202
if use_ssl:

0 commit comments

Comments
 (0)