Skip to content

Commit 272bf18

Browse files
committed
Testing: pandas 2.2 no longer supports SQLAlchemy 1.4
1 parent ab7b14c commit 272bf18

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/crate/client/sqlalchemy/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
from .compat.api13 import monkeypatch_add_exec_driver_sql
2323
from .dialect import CrateDialect
24-
from .sa_version import SA_1_4, SA_VERSION
24+
from .sa_version import SA_1_4, SA_2_0, SA_VERSION # noqa: F401
2525

2626

2727
if SA_VERSION < SA_1_4:

src/crate/client/sqlalchemy/tests/bulk_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import sqlalchemy as sa
2727
from sqlalchemy.orm import Session
2828

29-
from crate.client.sqlalchemy.sa_version import SA_VERSION, SA_2_0, SA_1_4
29+
from crate.client.sqlalchemy.sa_version import SA_VERSION, SA_2_0
3030

3131
try:
3232
from sqlalchemy.orm import declarative_base
@@ -170,7 +170,7 @@ def test_bulk_save_modern(self):
170170
self.assertSequenceEqual(expected_bulk_args, bulk_args)
171171

172172
@skipIf(sys.version_info < (3, 8), "SQLAlchemy/pandas is not supported on Python <3.8")
173-
@skipIf(SA_VERSION < SA_1_4, "SQLAlchemy 1.3 is not supported by pandas")
173+
@skipIf(SA_VERSION < SA_2_0, "SQLAlchemy 1.4 is no longer supported by pandas 2.2")
174174
@patch('crate.client.connection.Cursor', mock_cursor=FakeCursor)
175175
def test_bulk_save_pandas(self, mock_cursor):
176176
"""
@@ -209,7 +209,7 @@ def test_bulk_save_pandas(self, mock_cursor):
209209
self.assertEqual(effective_op_count, OPCOUNT)
210210

211211
@skipIf(sys.version_info < (3, 8), "SQLAlchemy/Dask is not supported on Python <3.8")
212-
@skipIf(SA_VERSION < SA_1_4, "SQLAlchemy 1.3 is not supported by pandas")
212+
@skipIf(SA_VERSION < SA_2_0, "SQLAlchemy 1.4 is no longer supported by pandas 2.2")
213213
@patch('crate.client.connection.Cursor', mock_cursor=FakeCursor)
214214
def test_bulk_save_dask(self, mock_cursor):
215215
"""

src/crate/client/tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
crate_host, crate_path, crate_port, \
4242
crate_transport_port, docs_path, localhost
4343
from crate.client import connect
44-
from .sqlalchemy import SA_VERSION, SA_1_4
44+
from .sqlalchemy import SA_VERSION, SA_2_0
4545

4646
from .test_cursor import CursorTest
4747
from .test_connection import ConnectionTest
@@ -395,7 +395,7 @@ def test_suite():
395395
]
396396

397397
# Don't run DataFrame integration tests on SQLAlchemy 1.3 and Python 3.7.
398-
skip_dataframe = SA_VERSION < SA_1_4 or sys.version_info < (3, 8)
398+
skip_dataframe = SA_VERSION < SA_2_0 or sys.version_info < (3, 8)
399399
if not skip_dataframe:
400400
sqlalchemy_integration_tests += [
401401
'docs/by-example/sqlalchemy/dataframe.rst',

0 commit comments

Comments
 (0)