Adjust connect arguments to accept credentials within the HTTP URI

Author: amotl

CHANGES.txt

@@ -11,6 +11,8 @@ Unreleased
   HTTP by default. Previously, this setting defaulted to false. This setting
   can be changed via the ``verify_ssl_cert`` connection parameter.
 
+- Adjusted connect arguments to accept credentials within the HTTP URI.
+
 2020/09/28 0.26.0
 =================
 

src/crate/client/doctests/client.txt

@@ -47,13 +47,36 @@ connect::
 
     >>> connection = client.connect([crate_host],
     ...                             username='trusted_me')
+    >>> connection.client.username
+    'trusted_me'
+    >>> connection.client.password
+
+The username for trusted users can also be provided in the URL::
+
+    >>> connection = client.connect(['http://trusted_me@' + crate_host])
+    >>> connection.client.username
+    'trusted_me'
+    >>> connection.client.password
 
 To connect to CrateDB with as a user that requires password authentication, you
 also need to provide ``password`` as argument for the ``connect()`` call::
 
     >>> connection = client.connect([crate_host],
     ...                             username='me',
     ...                             password='my_secret_pw')
+    >>> connection.client.username
+    'me'
+    >>> connection.client.password
+    'my_secret_pw'
+
+The authentication credentials can also be provided in the URL::
+
+    >>> connection = client.connect(['http://me:my_secret_pw@' + crate_host])
+    >>> connection.client.username
+    'me'
+    >>> connection.client.password
+    'my_secret_pw'
+
 
 Default Schema
 --------------

src/crate/client/http.py

@@ -346,6 +346,22 @@ def __init__(self,
             servers = [self.default_server]
         else:
             servers = _to_server_list(servers)
+
+        # Try to derive credentials from first server argument if not
+        # explicitly given.
+        if servers and not username:
+            try:
+                url = urlparse(servers[0])
+                if url.username is not None:
+                    username = url.username
+                if url.password is not None:
+                    password = url.password
+            except Exception as ex:
+                logger.warning("Unable to decode credentials from database "
+                               "URI, so connecting to CrateDB without "
+                               "authentication: {ex}"
+                               .format(ex=ex))
+
         self._active_servers = servers
         self._inactive_servers = []
         pool_kw = _pool_kw_args(