test clang-tidy --extra-arg is appended to command args

also adjust testing CI workflow (typo & remove default option)

Author: 2bndy5

.github/workflows/run-dev-tests.yml

@@ -48,7 +48,7 @@ jobs:
         with:
           tool: cargo-nextest,cargo-llvm-cov,cargo-binstall
 
-      - name: Install llvm-cov-pretty (HTL report generator)
+      - name: Install llvm-cov-pretty (HTML report generator)
         run: cargo binstall -y llvm-cov-pretty
 
       - uses: actions/setup-python@v5
@@ -90,7 +90,7 @@ jobs:
         working-directory: cpp-linter-lib
         env:
           CLANG_VERSION: ${{ matrix.version }}
-        run: cargo llvm-cov --hide-instantiations --lib --no-report nextest
+        run: cargo llvm-cov --lib --no-report nextest
 
       - name: Generate Coverage HTML report
         working-directory: cpp-linter-lib

cpp-linter-lib/src/clang_tools/clang_tidy.rs

@@ -204,11 +204,20 @@ pub fn run_clang_tidy(
 
 #[cfg(test)]
 mod test {
+    use std::{env, path::PathBuf, process::Command};
+
+    use regex::Regex;
+
+    use crate::{clang_tools::get_clang_tool_exe, common_fs::FileObj};
+
+    use super::run_clang_tidy;
+
+    // ***************** test for regex parsing of clang-tidy stdout
+
     #[test]
     fn test_capture() {
         let src = "tests/demo/demo.hpp:11:11: warning: use a trailing return type for this function [modernize-use-trailing-return-type]";
-        let pat =
-            regex::Regex::new(r"^(.+):(\d+):(\d+):\s(\w+):(.*)\[([a-zA-Z\d\-\.]+)\]$").unwrap();
+        let pat = Regex::new(r"^(.+):(\d+):(\d+):\s(\w+):(.*)\[([a-zA-Z\d\-\.]+)\]$").unwrap();
         let cap = pat.captures(src).unwrap();
         assert_eq!(
             cap.get(0).unwrap().as_str(),
@@ -224,4 +233,36 @@ mod test {
             .as_str()
         )
     }
+
+    #[test]
+    fn use_extra_args() {
+        let exe_path = get_clang_tool_exe(
+            "clang-tidy",
+            env::var("CLANG_VERSION").unwrap_or("".to_string()).as_str(),
+        )
+        .unwrap();
+        let mut cmd = Command::new(exe_path);
+        let file = FileObj::new(PathBuf::from("tests/demo/demo.cpp"));
+        let extra_args = vec!["-std=c++17", "-Wall"];
+        let tidy_advice = run_clang_tidy(
+            &mut cmd,
+            &file,
+            "",                // use .clang-tidy config file
+            0,                 // check all lines
+            &None,             // no database path
+            &Some(extra_args), // <---- the reason for this test
+            &None,             // no deserialized database
+        );
+        // since `cmd` was passed as a mutable reference, we can inspect the args that were added
+        let mut args = cmd
+            .get_args()
+            .map(|arg| arg.to_str().unwrap())
+            .collect::<Vec<&str>>();
+        assert_eq!(file.name.to_string_lossy(), args.pop().unwrap());
+        assert_eq!(
+            vec!["--extra-arg", "\"-std=c++17\"", "--extra-arg", "\"-Wall\""],
+            args
+        );
+        assert!(!tidy_advice.is_empty());
+    }
 }

cpp-linter-lib/src/rest_api/github_api.rs

@@ -105,7 +105,7 @@ impl RestApiClient for GithubApiClient {
                 .expect("GITHUB_OUTPUT file could not be opened");
             if let Err(e) = writeln!(
                 gh_out_file,
-                "checks-failed={}\nformat-checks-failed={}\ntidy-checks-failed={}\n",
+                "checks-failed={}\nformat-checks-failed={}\ntidy-checks-failed={}",
                 checks_failed,
                 format_checks_failed.unwrap_or(0),
                 tidy_checks_failed.unwrap_or(0),