cleanup '#pragma warning disable'

Author: Bertk

src/coverlet.core/Helpers/InstrumentationHelper.cs

@@ -468,10 +468,8 @@ private static bool IsTypeFilterMatch(string module, string type, string[] filte
 
       foreach (string filter in filters)
       {
-#pragma warning disable IDE0057 // Use range operator
         string typePattern = filter.Substring(filter.IndexOf(']') + 1);
         string modulePattern = filter.Substring(1, filter.IndexOf(']') - 1);
-#pragma warning restore IDE0057 // Use range operator
 
         typePattern = WildcardToRegex(typePattern);
         modulePattern = WildcardToRegex(modulePattern);

src/coverlet.core/Helpers/SourceRootTranslator.cs

@@ -101,11 +101,9 @@ private Dictionary<string, List<SourceRootMapping>> LoadSourceRootMapping(string
           _logger.LogWarning($"Malformed mapping '{mappingRecord}'");
           continue;
         }
-#pragma warning disable IDE0057 // Use range operator
         string projectPath = mappingRecord.Substring(0, projectFileSeparatorIndex);
         string originalPath = mappingRecord.Substring(projectFileSeparatorIndex + 1, pathMappingSeparatorIndex - projectFileSeparatorIndex - 1);
         string mappedPath = mappingRecord.Substring(pathMappingSeparatorIndex + 1);
-#pragma warning restore IDE0057 // Use range operator
 
         if (!mapping.ContainsKey(mappedPath))
         {

src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs

@@ -244,10 +244,8 @@ public NetCoreSharedFrameworkResolver(string modulePath, ILogger logger)
         var semVersion = NuGetVersion.Parse(frameworkVersion);
         var directory = new DirectoryInfo(Path.Combine(runtimeRootPath, frameworkName));
         string majorVersion = $"{semVersion.Major}.{semVersion.Minor}.";
-#pragma warning disable IDE0057 // Use range operator
         uint latestVersion = directory.GetDirectories().Where(x => x.Name.StartsWith(majorVersion))
             .Select(x => Convert.ToUInt32(x.Name.Substring(majorVersion.Length))).Max();
-#pragma warning restore IDE0057 // Use range operator
         _aspNetSharedFrameworkDirs.Add(Directory.GetDirectories(directory.FullName, majorVersion + $"{latestVersion}*", SearchOption.TopDirectoryOnly)[0]);
       }
 

src/coverlet.core/Instrumentation/Instrumenter.cs

@@ -463,9 +463,7 @@ private void InstrumentType(TypeDefinition type)
         MethodDefinition actualMethod = method;
         IEnumerable<CustomAttribute> customAttributes = method.CustomAttributes;
         if (_instrumentationHelper.IsLocalMethod(method.Name))
-#pragma warning disable IDE0057 // Use range operator
           actualMethod = methods.FirstOrDefault(m => m.Name == method.Name.Split('>')[0].Substring(1)) ?? method;
-#pragma warning restore IDE0057 // Use range operator
 
         if (actualMethod.IsGetter || actualMethod.IsSetter)
         {
@@ -927,9 +925,7 @@ public ExcludedFilesHelper(string[] excludes, ILogger logger)
           {
             continue;
           }
-#pragma warning disable IDE0057 // Use range operator
           _matcher.AddInclude(Path.IsPathRooted(excludeRule) ? excludeRule.Substring(Path.GetPathRoot(excludeRule).Length) : excludeRule);
-#pragma warning restore IDE0057 // Use range operator
         }
       }
     }
@@ -940,9 +936,7 @@ public bool Exclude(string sourceFile)
         return false;
 
       // We strip out drive because it doesn't work with globbing
-#pragma warning disable IDE0057 // Use range operator
       return _matcher.Match(Path.IsPathRooted(sourceFile) ? sourceFile.Substring(Path.GetPathRoot(sourceFile).Length) : sourceFile).HasMatches;
-#pragma warning restore IDE0057 // Use range operator
     }
   }
 }

src/coverlet.core/Reporters/CoberturaReporter.cs

@@ -224,9 +224,7 @@ private static string GetRelativePathFromBase(IEnumerable<string> basePaths, str
       {
         if (path.StartsWith(basePath))
         {
-#pragma warning disable IDE0057 // Use range operator
           return path.Substring(basePath.Length);
-#pragma warning restore IDE0057 // Use range operator
         }
       }
       return path;

test/coverlet.integration.tests/BaseTest.cs

@@ -45,9 +45,7 @@ private protected string GetPackageVersion(string filter)
         using var reader = new PackageArchiveReader(pkg);
         using Stream nuspecStream = reader.GetNuspec();
         var manifest = Manifest.ReadFrom(nuspecStream, false);
-#pragma warning disable CS8603 // Possible null reference return.
-        return manifest.Metadata.Version.OriginalVersion;
-#pragma warning restore CS8603 // Possible null reference return.
+        return manifest.Metadata.Version?.OriginalVersion ?? throw new InvalidOperationException("Version is null");
       }
     }