PYCBC-1679: Disable console logger if file logger specified

Changes
=======
* If the `PYCBC_LOG_FILE` environment variable is set (enabling the C++
  core file logger), the C++ console logger will be disabled.
* If the file logger is enabled, the console logger may also be enabled
  if the `PYCBC_ENABLE_CONSOLE` environment variable is set.

Change-Id: I008f780760674b967fda9e0f3f370af1652812a6
Reviewed-on: https://review.couchbase.org/c/couchbase-python-client/+/226431
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dimitris Christodoulou <[email protected]>

Author: thejcfactor

couchbase/__init__.py

@@ -146,7 +146,10 @@ def configure_console_logger():
     if log_level:
         log_file = os.getenv('PYCBC_LOG_FILE', None)
         if log_file:
-            _PYCBC_LOGGER.create_logger(level=log_level.lower(), filename=log_file)
+            enable_console_logging = 0 if os.getenv('PYCBC_ENABLE_CONSOLE', None) is None else 1
+            _PYCBC_LOGGER.create_logger(level=log_level.lower(),
+                                        filename=log_file,
+                                        enable_console=enable_console_logging)
         else:
             _PYCBC_LOGGER.create_logger(level=log_level.lower())
         logging.getLogger().debug(get_metadata(as_str=True))

src/logger.cxx

@@ -71,10 +71,16 @@ pycbc_logger__create_logger__(PyObject* self, PyObject* args, PyObject* kwargs)
   auto logger = reinterpret_cast<pycbc_logger*>(self);
   char* log_level = nullptr;
   char* log_filename = nullptr;
-  const char* kw_list[] = { "level", "filename", nullptr };
-  const char* kw_format = "s|s";
-  if (!PyArg_ParseTupleAndKeywords(
-        args, kwargs, kw_format, const_cast<char**>(kw_list), &log_level, &log_filename)) {
+  int enable_console = 0;
+  const char* kw_list[] = { "level", "filename", "enable_console", nullptr };
+  const char* kw_format = "s|si";
+  if (!PyArg_ParseTupleAndKeywords(args,
+                                   kwargs,
+                                   kw_format,
+                                   const_cast<char**>(kw_list),
+                                   &log_level,
+                                   &log_filename,
+                                   &enable_console)) {
     pycbc_set_python_exception(PycbcError::InvalidArgument,
                                __FILE__,
                                __LINE__,
@@ -103,6 +109,7 @@ pycbc_logger__create_logger__(PyObject* self, PyObject* args, PyObject* kwargs)
     couchbase::core::logger::configuration configuration{};
     configuration.filename = std::string{ log_filename };
     configuration.log_level = level;
+    configuration.console = enable_console > 0;
     couchbase::core::logger::create_file_logger(configuration);
     logger->is_file_logger = true;
   } else {