Skip to content

Abandoned QueryStream calls to ingesters should get canceled #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bboreham opened this issue Sep 14, 2020 · 0 comments · Fixed by #3178
Closed

Abandoned QueryStream calls to ingesters should get canceled #3169

bboreham opened this issue Sep 14, 2020 · 0 comments · Fixed by #3178
Labels
component/querier type/performance

Comments

@bboreham
Copy link
Contributor

Queries are satisfied when (N-1) of the calls return, but the Nth one can still be doing work and chewing up resources.

Illustrative trace:
image

I think the cancellation could be done in ReplicationSet.Do()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/querier type/performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cancel abandoned operations in ReplicationSet.Do() cortexproject/cortex
1 participant
@bboreham