Skip to content

Commit 01f29f4

Browse files
committed
Rework test
Signed-off-by: Daniel Deluiggi <[email protected]>
1 parent fb1aaca commit 01f29f4

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

pkg/ring/kv/dynamodb/client_test.go

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -192,20 +192,23 @@ func Test_WatchPrefix(t *testing.T) {
192192
c := NewClientMock(ddbMock, codecMock, TestLogger{}, prometheus.NewPedanticRegistry())
193193
data := map[string][]byte{}
194194
dataKey := []string{"t1", "t2"}
195-
data[dataKey[0]] = []byte("data" + dataKey[0])
196-
data[dataKey[1]] = []byte("data" + dataKey[1])
195+
data[dataKey[0]] = []byte(dataKey[0])
196+
data[dataKey[1]] = []byte(dataKey[1])
197197
calls := 0
198198

199-
ddbMock.On("Query").Return(data, nil).Once()
199+
ddbMock.On("Query").Return(data, nil)
200200
codecMock.On("Decode").Twice()
201201

202202
c.WatchPrefix(context.TODO(), key, func(key string, i interface{}) bool {
203-
ddbMock.AssertNumberOfCalls(t, "Query", 1)
204-
require.EqualValues(t, key, dataKey[calls])
205-
require.EqualValues(t, string(data[dataKey[calls]]), i)
203+
require.EqualValues(t, string(data[key]), i)
204+
delete(data, key)
206205
calls++
207-
return calls < 1
206+
return calls < 2
208207
})
208+
209+
require.True(t, len(data) == 0)
210+
211+
ddbMock.AssertNumberOfCalls(t, "Query", 1)
209212
}
210213

211214
func Test_UpdateStaleData(t *testing.T) {

0 commit comments

Comments
 (0)