From d6b99b5dd26ef5f8e51070b379377bde830ebffd Mon Sep 17 00:00:00 2001 From: Friedrich Gonzalez Date: Wed, 26 Oct 2022 18:42:10 +0200 Subject: [PATCH] Support new cache metrics Signed-off-by: Friedrich Gonzalez --- CHANGELOG.md | 1 + cortex-mixin/dashboards/queries.libsonnet | 15 ++++++++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5d86d00..0ca5e95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ * [CHANGE] Use integrated cortex overrides exporter * [ENHANCEMENT] Added main.jsonnet examples for azure, gcs and s3 * [ENHANCEMENT] How to rename buckets in AWS and Azure for `not healthy index found` playbook. #5 +* [ENHANCEMENT] Support new metrics cortex_cache_fetched_keys_total and cortex_cache_fetched_keys_total * [BUGFIX] Updated blocks_storage_s3_endpoint in config.libsonnet to include the correct aws region ## 1.11.0 / 2021-12-30 diff --git a/cortex-mixin/dashboards/queries.libsonnet b/cortex-mixin/dashboards/queries.libsonnet index 259f5df..f18cdee 100644 --- a/cortex-mixin/dashboards/queries.libsonnet +++ b/cortex-mixin/dashboards/queries.libsonnet @@ -46,12 +46,18 @@ local utils = import 'mixin-utils/utils.libsonnet'; ) .addPanel( $.panel('Results Cache Hit %') + - $.queryPanel('sum(rate(cortex_cache_hits{name=~"frontend.+", %s}[1m])) / sum(rate(cortex_cache_fetched_keys{name=~"frontend.+", %s}[1m]))' % [$.jobMatcher($._config.job_names.query_frontend), $.jobMatcher($._config.job_names.query_frontend)], 'Hit Rate') + + $.queryPanel(||| + sum(rate(cortex_cache_hits{name=~"frontend.+", %(q)s}[1m])) / sum(rate(cortex_cache_fetched_keys{name=~"frontend.+", %(q)s}[1m])) or + sum(rate(cortex_cache_hits_total{name=~"frontend.+", %(q)s}[1m])) / sum(rate(cortex_cache_fetched_keys_total{name=~"frontend.+", %(q)s}[1m])) + ||| % { q: $.jobMatcher($._config.job_names.query_frontend) }, 'Hit Rate') + { yaxes: $.yaxes({ format: 'percentunit', max: 1 }) }, ) .addPanel( $.panel('Results Cache misses') + - $.queryPanel('sum(rate(cortex_cache_fetched_keys{name=~"frontend.+", %s}[1m])) - sum(rate(cortex_cache_hits{name=~"frontend.+", %s}[1m]))' % [$.jobMatcher($._config.job_names.query_frontend), $.jobMatcher($._config.job_names.query_frontend)], 'Miss Rate'), + $.queryPanel(||| + sum(rate(cortex_cache_fetched_keys{name=~"frontend.+", %(q)s}[1m])) - sum(rate(cortex_cache_hits{name=~"frontend.+", %(q)s}[1m])) or + sum(rate(cortex_cache_fetched_keys_total{name=~"frontend.+", %(q)s}[1m])) - sum(rate(cortex_cache_hits_total{name=~"frontend.+", %(q)s}[1m])) + ||| % { q: $.jobMatcher($._config.job_names.query_frontend) }, 'Miss Rate'), ) ) .addRow( @@ -94,7 +100,10 @@ local utils = import 'mixin-utils/utils.libsonnet'; ) .addPanel( $.panel('Chunk cache misses') + - $.queryPanel('sum(rate(cortex_cache_fetched_keys{%s,name="chunksmemcache"}[1m])) - sum(rate(cortex_cache_hits{%s,name="chunksmemcache"}[1m]))' % [$.jobMatcher($._config.job_names.querier), $.jobMatcher($._config.job_names.querier)], 'Hit rate'), + $.queryPanel(||| + sum(rate(cortex_cache_fetched_keys{%(q)s,name="chunksmemcache"}[1m])) - sum(rate(cortex_cache_hits{%(q)s,name="chunksmemcache"}[1m])) or + sum(rate(cortex_cache_fetched_keys_total{%(q)s,name="chunksmemcache"}[1m])) - sum(rate(cortex_cache_hits_total{%(q)s,name="chunksmemcache"}[1m])) + ||| % { q: $.jobMatcher($._config.job_names.query_frontend) }, 'Hit rate'), ) .addPanel( $.panel('Chunk cache corruptions') +