Skip to content

Modal: closes if onmouseup event is outside of the modal #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
ehni opened this issue Jul 30, 2021 · 2 comments
Closed
3 tasks done

Modal: closes if onmouseup event is outside of the modal #153

ehni opened this issue Jul 30, 2021 · 2 comments

Comments

@ehni
Copy link

ehni commented Jul 30, 2021

Dear coreui-vue Team,

I think there might be a bug within the modal.

Before opening an issue:

What's wrong

When you open the modal and highlight some text the modal closes if the onmouseup event happens outside of the modal. This can lead to confusion when e.g. selecting some text.

The example modal in the official docs already show the behaviour: https://coreui.io/vue/docs/components/modal.html

Example video

modal_behaviour

Expected behaviour

When the onmousedown event happens inside the modal the onmouseup event should not close the modal, even if it happens outside of the modal.

The expected behaviour is e.g. shown in the vuematerial modal: https://vuematerial.io/components/dialog/

Example video

modal_expected_behaviour

@ehni
Copy link
Author

ehni commented Aug 13, 2021

There was no reaction for a few days now.

Reaching out to @xidedix. Is the modal behaviour expected?

I prepared a PR for this with #154

@mrholek
Copy link
Member

mrholek commented Nov 30, 2021

@ehmi I found a solution in the next release I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants