Merge pull request #119 from fyntex/feature/add-python-3.8-support

Add support for Python 3.8

Author: jtrh

.circleci/config.yml

@@ -9,11 +9,16 @@
 #   - https://circleci.com/docs/2.0/language-python/ for more details
 #   - https://circleci.com/docs/2.0/configuration-reference/
 #
-version: 2
+version: "2.1"
+
 jobs:
-  test-py37:
+  test:
+    parameters:
+      python_version:
+        type: string
+
     docker:
-      - image: python:3.7.2
+      - image: python:<< parameters.python_version >>
 
     working_directory: ~/repo
 
@@ -34,7 +39,14 @@ jobs:
           command: |
             . venv/bin/activate
             make lint
-            tox -e py37
+
+            # Set Tox environment to the installed Python version.
+            TOXENV=$(
+              python -c 'import sys; v = sys.version_info; print("py{}{}".format(v.major, v.minor))'
+            )
+
+            tox -e "$TOXENV"
+
             codecov
             make test-coverage-report-console
             make test-coverage-report-html
@@ -75,5 +87,11 @@ workflows:
   version: 2
   ci:
     jobs:
-      - test-py37
+      - test:
+          matrix:
+            parameters:
+              python_version:
+                - "3.7.2"
+                - "3.7.6"
+                - "3.8.3"
       - dist

README.rst

@@ -43,8 +43,8 @@ Status
 Supported Python versions
 -------------------------
 
-Only Python 3.7. Python 3.6 and below will not work because we use some features introduced in
-Python 3.7.
+Only Python 3.7 and 3.8. Python 3.6 and below will not work because we use some features introduced
+in Python 3.7.
 
 Quickstart
 ----------

setup.py

@@ -75,6 +75,7 @@ def get_version(*file_paths: Sequence[str]) -> str:
         'Natural Language :: English',
         'Programming Language :: Python :: 3',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
     ],
     description="""Python library for Servicio de Impuestos Internos (SII) of Chile.""",
     extras_require=extras_requirements,
@@ -86,7 +87,7 @@ def get_version(*file_paths: Sequence[str]) -> str:
     name='cl-sii',
     package_data=_package_data,
     packages=find_packages(exclude=['docs', 'tests*']),
-    python_requires='>=3.7, <3.8',
+    python_requires='>=3.7, <3.9',
     setup_requires=setup_requirements,
     test_suite='tests',
     tests_require=test_requirements,

tests/test_libs_io_utils.py

@@ -1,5 +1,6 @@
 import io
 import pathlib
+import sys
 import tempfile
 import unittest
 
@@ -69,8 +70,11 @@ def test_with_encoding_utf8(self):
 
         with tempfile.SpooledTemporaryFile(mode='rt', encoding='utf-8') as f:
             self.assertTrue(isinstance(f, tempfile.SpooledTemporaryFile))
-            # note: this is a strange case.
-            self.assertFalse(with_encoding_utf8(f))
+            if sys.version_info[:3] >= (3, 7, 6):
+                self.assertTrue(with_encoding_utf8(f))
+            else:
+                # note: this is a strange case (Python 3.7).
+                self.assertFalse(with_encoding_utf8(f))
 
         # Text mode - encoding 'latin1'
 

tox.ini

@@ -1,6 +1,7 @@
 [tox]
 envlist =
-    py37
+    py37,
+    py38,
 
 [testenv]
 setenv =
@@ -10,3 +11,4 @@ deps =
     -r{toxinidir}/requirements/test.txt
 basepython =
     py37: python3.7
+    py38: python3.8